New issue
Advanced search Search tips

Issue 683842 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

A CL author should clearly see which reviewer is a committer

Project Member Reported by machenb...@chromium.org, Jan 23 2017

Issue description

It is not obvious to an author, if they can get committer +1 from a reviewer or not. This leads to reviewers being added, which in turn have no idea what button to press or how to respond.

It should be clear throughout the review process, who's able to do CR+1 and who not. E.g. the reviewers could get different colors in the UI, maybe already the moment they are added.

Optionally, if a non-committer reviewer is added on a CL, it would be nice if there was a formal response option for that person too.
 
Cc: aga...@chromium.org
Labels: Milestone-Afterglow
Status: Available (was: Untriaged)
Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.

Comment 3 by aga...@chromium.org, Mar 27 2018

Labels: Pri-3
I like this idea a lot; I don't know why I haven't seen this particular bug before. It's definitely highly non-trivial to implement, and may have privacy implications to boot, so I'm sticking it at Pri-3, but I hope we can get to it.

Sign in to add a comment