New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683811 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

PermissionBlacklistClient should check the return value of CheckApiBlacklistUrl

Project Member Reported by raymes@chromium.org, Jan 23 2017

Issue description

If CheckApiBlacklistUrl then the URL is known to be safe and the callback will never be called. Right now we're not checking the return value so we might miss some cases where the callback won't ever be called.
 

Comment 1 by raymes@chromium.org, Jan 23 2017

Components: Internals>Permissions>CrowdConsent
As part of this we should also add a test that ensures we do not block blacklisted sites when SB is turned off.
With regards to your question, you can turn SB off by setting the pref. See an example here: https://cs.chromium.org/chromium/src/chrome/browser/permissions/permission_uma_util_unittest.cc?sq=package:chromium&dr=CSs&l=134
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48ad1681cf6efac487c260d75ac5d5f35ab493e3

commit 48ad1681cf6efac487c260d75ac5d5f35ab493e3
Author: meredithl <meredithl@google.com>
Date: Wed Feb 08 03:15:37 2017

Check result of ApiBlacklist query in client.

If the API blacklist query can be responded to synchronously, the Safe
Browsing Database Manager will respond true to the calling client. This
was not being checked previously, and hence the callback method on the
client not being called.

BUG= 683811 

Review-Url: https://codereview.chromium.org/2684523002
Cr-Commit-Position: refs/heads/master@{#448888}

[modify] https://crrev.com/48ad1681cf6efac487c260d75ac5d5f35ab493e3/chrome/browser/permissions/permission_blacklist_client.cc
[modify] https://crrev.com/48ad1681cf6efac487c260d75ac5d5f35ab493e3/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/48ad1681cf6efac487c260d75ac5d5f35ab493e3/chrome/browser/permissions/permission_decision_auto_blocker.cc
[modify] https://crrev.com/48ad1681cf6efac487c260d75ac5d5f35ab493e3/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc

Owner: dominickn@chromium.org
Status: Fixed (was: Assigned)
#2: I'm not really sure we test that we don't block blacklisted sites when Safe Browsing is turned off. Either:

 * We mock out the database manager, in which case turning Safe Browsing off is irrelevant, or
 * We use the real Safe Browsing Service, and turn it off, but we have no way of injecting a guaranteed blacklisted page for the test that verifies it isn't blocked

Marking as fixed for now.

Sign in to add a comment