New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 683794 link

Starred by 3 users
Status: Fixed
Owner:
█ tibell@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ hdodda@chromium.org
█ brajkumar@chromium.org
█ tibell@chromium.org
█ durga.behera@chromium.org
sa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Missing close of browser RouterProvider binding on renderer death

Project Member Reported by tibell@chromium.org, Jan 23 2017 
After a renderer has died (e.g. because you chrome:kill-ed it) and have been restarted (e.g. due to reloading the tab) all associated interface connection requests initiated by the new renderer process will fail due to lack of state clean-up in the RPH.

When the new renderer connects this code will get run:

void RenderProcessHostImpl::OnRouteProviderRequest(
    mojom::RouteProviderAssociatedRequest request) {
  if (route_provider_binding_.is_bound())
    return;
  route_provider_binding_.Bind(std::move(request));
}

However, route_provider_binding_ is never closed when the previous process crashed.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d9f1c2e1cf7a167d2e0737692b18e5e68cbe71b

commit 4d9f1c2e1cf7a167d2e0737692b18e5e68cbe71b
Author: tibell <tibell@chromium.org>
Date: Mon Jan 23 22:46:25 2017

Close browser RouterProvider binding on renderer death

BUG= 683794 

Review-Url: https://codereview.chromium.org/2652573002
Cr-Commit-Position: refs/heads/master@{#445523}

[modify] https://crrev.com/4d9f1c2e1cf7a167d2e0737692b18e5e68cbe71b/content/browser/renderer_host/render_process_host_impl.cc

Comment 2 by tibell@chromium.org, Jan 23 2017

Blocking: -683021

Comment 3 by tibell@chromium.org, Jan 23 2017

Blocking: 683021
Cc: durga.behera@chromium.org ajha@chromium.org kavvaru@chromium.org tibell@chromium.org brajkumar@chromium.org hdodda@chromium.org
 Issue 683021  has been merged into this issue.

Comment 4 by tibell@chromium.org, Jan 23 2017

Labels: ReleaseBlock-Stable M-57 Merge-Request-57
Status: Fixed (was: Started)

Comment 5 by tibell@chromium.org, Jan 23 2017

Blocking: -683021
Labels: -Pri-3 Pri-1

Comment 6 by tibell@chromium.org, Jan 23 2017

Cc: sa...@chromium.org

Comment 7 by gov...@chromium.org, Jan 24 2017 

Is this change applicable to All OSs or any  specific OS?

Comment 8 by tibell@chromium.org, Jan 24 2017 

Should be all OSes.

Comment 9 by gov...@chromium.org, Jan 24 2017

Labels: OS-All
Project Member

Comment 10 by sheriffbot@chromium.org, Jan 24 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by tibell@chromium.org, Jan 24 2017 

Sam could you please merge this for me?
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 24 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d50a786e94698ab4b5a431cae404f5f080c076a

commit 7d50a786e94698ab4b5a431cae404f5f080c076a
Author: Sam McNally <sammc@chromium.org>
Date: Tue Jan 24 23:10:02 2017

Close browser RouterProvider binding on renderer death

BUG= 683794 

Review-Url: https://codereview.chromium.org/2652573002
Cr-Commit-Position: refs/heads/master@{#445523}
(cherry picked from commit 4d9f1c2e1cf7a167d2e0737692b18e5e68cbe71b)

Review-Url: https://codereview.chromium.org/2653133002 .
Cr-Commit-Position: refs/branch-heads/2987@{#77}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/7d50a786e94698ab4b5a431cae404f5f080c076a/content/browser/renderer_host/render_process_host_impl.cc
►

Sign in to add a comment