New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 683791 link

Starred by 2 users
Status: Fixed
Owner:
█ kcaratt...@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
dominickn@chromium.org
vakh@chromium.org
█ meredithl@google.com
nparker@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Check whether DB is enabled in CheckApiBlacklistUrl()

Project Member Reported by kcaratt...@chromium.org, Jan 23 2017 
We need to check enabled_ in the CheckApiBlacklistUrl() call in the Safe Browsing database manager.  That will tell us if SB is enabled.
(SB disabled leads to dbmgr->enabled_=false).
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0fa01b10bf10faae9ac8ff604a91c6130377491

commit f0fa01b10bf10faae9ac8ff604a91c6130377491
Author: kcarattini <kcarattini@chromium.org>
Date: Wed Jan 25 02:17:07 2017

Safe Browsing: Move enabled_ to the base DatabaseManager class.

Moves the enabled_ member to the SafeBrowsingDatabaseManager base class and checks enabled_ in CheckApiBlacklistUrl().

Note that this changes the order in which enabled_ gets set in some of the subclasses.

BUG= 683791 

Review-Url: https://codereview.chromium.org/2648193002
Cr-Commit-Position: refs/heads/master@{#445913}

[modify] https://crrev.com/f0fa01b10bf10faae9ac8ff604a91c6130377491/chrome/browser/safe_browsing/local_database_manager.cc
[modify] https://crrev.com/f0fa01b10bf10faae9ac8ff604a91c6130377491/chrome/browser/safe_browsing/local_database_manager.h
[modify] https://crrev.com/f0fa01b10bf10faae9ac8ff604a91c6130377491/components/safe_browsing_db/database_manager.cc
[modify] https://crrev.com/f0fa01b10bf10faae9ac8ff604a91c6130377491/components/safe_browsing_db/database_manager.h
[modify] https://crrev.com/f0fa01b10bf10faae9ac8ff604a91c6130377491/components/safe_browsing_db/remote_database_manager.cc
[modify] https://crrev.com/f0fa01b10bf10faae9ac8ff604a91c6130377491/components/safe_browsing_db/remote_database_manager.h
[modify] https://crrev.com/f0fa01b10bf10faae9ac8ff604a91c6130377491/components/safe_browsing_db/test_database_manager.cc
[modify] https://crrev.com/f0fa01b10bf10faae9ac8ff604a91c6130377491/components/safe_browsing_db/test_database_manager.h
[modify] https://crrev.com/f0fa01b10bf10faae9ac8ff604a91c6130377491/components/safe_browsing_db/v4_local_database_manager.cc
[modify] https://crrev.com/f0fa01b10bf10faae9ac8ff604a91c6130377491/components/safe_browsing_db/v4_local_database_manager.h

Comment 2 by kcaratt...@chromium.org, Jan 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment