Issue 683781 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	----
Closed:	Jan 2018
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug
Arch-x86_64 Via-Wizard-Other

Deprecated methods with chrome_junit_tests

Project Member Reported by mar...@mwiacek.com, Jan 23 2017

Issue description

Steps to reproduce the problem:
ninja -C out/Release chrome_junit_tests

What is the expected behavior?

What went wrong?
Info about various deprecated elements in tests:

<T>isNotNull(Class<T>) in ArgumentMatchers has been deprecated

<T>isNull(Class<T>) in ArgumentMatchers has been deprecated

createDummySuggestions(int) in ContentSuggestionsTestUtils has been deprecated

<T>anyListOf(Class<T>) in ArgumentMatchers has been deprecated

ARGB_4444 in Config has been deprecated

Did this work before? N/A 

Chrome version: 57  Channel: canary
OS Version: 6
Flash Version: 

patch: https://codereview.chromium.org/2645243002/

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04617ab5401a00491238d22ae25bd5da5ce5f66d

commit 04617ab5401a00491238d22ae25bd5da5ce5f66d
Author: marcin <marcin@mwiacek.com>
Date: Sat Jan 28 00:59:32 2017

(Android) Removing deprecated methods in chrome_junit_tests

BUG= 683781 

Review-Url: https://codereview.chromium.org/2645243002
Cr-Commit-Position: refs/heads/master@{#446863}

[modify] https://crrev.com/04617ab5401a00491238d22ae25bd5da5ce5f66d/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java
[modify] https://crrev.com/04617ab5401a00491238d22ae25bd5da5ce5f66d/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java
[modify] https://crrev.com/04617ab5401a00491238d22ae25bd5da5ce5f66d/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
[modify] https://crrev.com/04617ab5401a00491238d22ae25bd5da5ce5f66d/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java
[modify] https://crrev.com/04617ab5401a00491238d22ae25bd5da5ce5f66d/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

Comment 2 by mar...@mwiacek.com, Dec 20 2017

can be closed...

Comment 3 by mar...@mwiacek.com, Jan 7 2018

Status: Fixed (was: Unconfirmed)

►

Issue 683781 link

Issue metadata

Deprecated methods with chrome_junit_tests

Issue description

Comment 1 by bugdroid1@chromium.org, Jan 28 2017

Comment 1 Deleted

Comment 2 by mar...@mwiacek.com, Dec 20 2017

Comment 2 Deleted

Comment 3 by mar...@mwiacek.com, Jan 7 2018

Comment 3 Deleted

Sign in to add a comment