New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683742 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until NaN
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 654129



Sign in to add a comment

[Blink API]: Get rid of Web* prefix in generated files and use hacker_case for naming

Project Member Reported by dglazkov@chromium.org, Jan 22 2017

Issue description

They should just have straight names in Chromium naming style.
 
Summary: [Blink API]: Get rid of Web* prefix in generated files and use hacker_case for naming (was: Get rid of Web* prefixes in Blink API generated files and use hacker_case for naming )
Components: Blink>Bindings
Labels: -Type-Bug Type-Feature
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574

commit e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574
Author: dglazkov <dglazkov@chromium.org>
Date: Thu Feb 09 15:11:19 2017

[WebAgent API]: Implement name style handling.

Since IDL names need to be represented in multiple different styles,
provide a single utility class for handling conversion, called
NameStyleConverter.

Start using this new utility class in templates.

R=bashi,yukishiino,haraken
BUG= 683742 

Review-Url: https://codereview.chromium.org/2684773003
Cr-Commit-Position: refs/heads/master@{#449291}

[modify] https://crrev.com/e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574/third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py
[modify] https://crrev.com/e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574/third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py
[add] https://crrev.com/e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574/third_party/WebKit/Source/bindings/scripts/name_style_converer_test.py
[add] https://crrev.com/e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574/third_party/WebKit/Source/bindings/scripts/name_style_converter.py
[modify] https://crrev.com/e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574/third_party/WebKit/Source/bindings/templates/templates.gni
[rename] https://crrev.com/e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574/third_party/WebKit/Source/bindings/templates/web_module_interface.cc.tmpl
[modify] https://crrev.com/e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574/third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl
[rename] https://crrev.com/e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
[rename] https://crrev.com/e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.h

Status: Fixed (was: Assigned)

Sign in to add a comment