New issue
Advanced search Search tips

Issue 683740 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 654129



Sign in to add a comment

[Blink API]: Rename WebModule-related bindings scripts to something better.

Project Member Reported by dglazkov@chromium.org, Jan 22 2017

Issue description

Webmodules are dead. Long live Blink API.
 
Summary: [Blink API]: Rename WebModule-related bindings scripts to Blink API (was: Rename WebModule-related bindings scripts to Blink API)
Components: Blink>Bindings
Labels: -Type-Bug Type-Feature
Summary: [Blink API]: Rename WebModule-related bindings scripts to something better. (was: [Blink API]: Rename WebModule-related bindings scripts to Blink API)
Cc: haraken@chromium.org esprehn@chromium.org bashi@chromium.org yukishiino@chromium.org ojan@chromium.org
Alright, I need a better name for the thing we called Webmodules. Here's the recap of where I am:

* The name for the thing that replaces RenderFrameObserver and enables writing DOM introspection logic outside of Blink is *Web Agents* (wip doc is here: https://docs.google.com/document/d/12nd__Mf5CX6iVLl0H7s6HO5jB2_bv_zbVcULwUg3GE0/edit#)

* I am currently tying to come up with a short, yet self-explanatory name of the introspection API that Web Agents use.

* This API may also be used for cases beyond Web Agents, but that is not currently something we're actively planning.

* The places where this name will be used: 1) The suffix of the code generator files, 2) the WebIDL custom attribute, 3) identification prefix for bugs like this one.

Here are my candidate names:

* WebAgentAPI -- explains in terms of specific, planned consumer, but maybe too narrow if we start using this API beyond Web Agents? Also, if found out of context in an IDL file, would it be confusing?

* EmbedderAPI -- explains in terms of general usage, might be less confusing in an IDL file, but "embedder" is not a clear term, either.

* WebCPPAPI -- explains precisely what it is, but is very vague in purpose.

WDYT? Any better ideas?

Also I am documenting for posterity that the initial idea was "BlinkAPI" -- definitely too vague: https://codereview.chromium.org/2648173002
I'd vote on WebAgentAPI. If we start using the API beyond Web Agents, you could expand the definition of Web Agents :)

Or WebCPPAPI.

My preference is
  WebAgentAPI, WebCppAPI > EmbedderAPI
and open to other better options, too.

Going with WebAgentAPI for now..
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51630b914ab57d747101e9aa11433ea63fd36b43

commit 51630b914ab57d747101e9aa11433ea63fd36b43
Author: dglazkov <dglazkov@chromium.org>
Date: Sat Feb 25 01:47:20 2017

Rename webmodule codegen bits to BlinkAPI.

Replace all references to webmodules with new terminology.

R=bashi,yukishiino
BUG= 683740 

Review-Url: https://codereview.chromium.org/2648173002
Cr-Commit-Position: refs/heads/master@{#453040}

[modify] https://crrev.com/51630b914ab57d747101e9aa11433ea63fd36b43/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt
[rename] https://crrev.com/51630b914ab57d747101e9aa11433ea63fd36b43/third_party/WebKit/Source/bindings/scripts/code_generator_web_agent_api.py
[rename] https://crrev.com/51630b914ab57d747101e9aa11433ea63fd36b43/third_party/WebKit/Source/bindings/scripts/code_generator_web_module_api_test.py
[modify] https://crrev.com/51630b914ab57d747101e9aa11433ea63fd36b43/third_party/WebKit/Source/bindings/scripts/scripts.gni
[modify] https://crrev.com/51630b914ab57d747101e9aa11433ea63fd36b43/third_party/WebKit/Source/bindings/templates/templates.gni
[rename] https://crrev.com/51630b914ab57d747101e9aa11433ea63fd36b43/third_party/WebKit/Source/bindings/templates/web_agent_api_interface.cc.tmpl
[rename] https://crrev.com/51630b914ab57d747101e9aa11433ea63fd36b43/third_party/WebKit/Source/bindings/templates/web_agent_api_interface.h.tmpl
[modify] https://crrev.com/51630b914ab57d747101e9aa11433ea63fd36b43/third_party/WebKit/Source/bindings/tests/idls/core/TestInterface3.idl
[modify] https://crrev.com/51630b914ab57d747101e9aa11433ea63fd36b43/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
[modify] https://crrev.com/51630b914ab57d747101e9aa11433ea63fd36b43/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.h
[modify] https://crrev.com/51630b914ab57d747101e9aa11433ea63fd36b43/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py

Cc: -yukishiino@chromium.org -haraken@chromium.org -esprehn@chromium.org -ojan@chromium.org -bashi@chromium.org slangley@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
slangley@, these are the bugs I owned around Web Agents. Please triage/close as you see fit.
Status: Fixed (was: Untriaged)
Actually, this one is done.

Sign in to add a comment