New issue
Advanced search Search tips

Issue 683731 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

[Payments] PR Dialog should close when navigating (same domain, different domain), reloading

Project Member Reported by ma...@chromium.org, Jan 22 2017

Issue description

Currently, the PR dialog stays open during the events described above. A better handling of the dialog's showing is required.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4bc50e24731fad2ef8ac320f6347aa60fe70532

commit f4bc50e24731fad2ef8ac320f6347aa60fe70532
Author: mathp <mathp@chromium.org>
Date: Tue Jan 24 05:17:50 2017

[Payments] Improve the closing of the PR dialog.

Various changes around the dialog's disappearance.
* The PaymentRequest object, through its delegate, can now close the
  dialog. This will need to happen if the Mojo pipe is closed by the
  renderer (can happen on failure or success of the PR logic).
* Similarly, when the user closes the dialog through an explicit
  action, the PaymentRequest object will inform the renderer and
  subsequently self destruct (this is not new but is improved)
* Some logic is added to avoid cycles: if the dialog is closing and it
  informs PaymentRequest, PaymentRequest will not ask to close it again
  (and vice versa). This is done through closing the bindings.
* abort() is implemented, it currently simply returns onAbort(true) to
  the caller (to be improved).
* As a result of the Mojo connection closing on navigation, reload,
  etc, the dialog will now close too.
* PaymentRequestDialog is renamed PaymentRequestDialogView and
  implements a new interface, PaymentRequestDialog.
* The tests are now a WidgetObserver to be warned of all possible
  closures of the dialog.

BUG= 683731 ,  679245 
TEST=PaymentRequest interactive_ui_tests

Review-Url: https://codereview.chromium.org/2649683002
Cr-Commit-Position: refs/heads/master@{#445652}

[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/payments/chrome_payment_request_delegate.cc
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/payments/chrome_payment_request_delegate.h
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/order_summary_view_controller.cc
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/order_summary_view_controller.h
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/payment_method_view_controller.h
[rename] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[rename] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/payment_request_interactive_uitest.cc
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.cc
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/payment_sheet_view_controller.h
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/components/payments/BUILD.gn
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/components/payments/payment_request.cc
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/components/payments/payment_request.h
[modify] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/components/payments/payment_request_delegate.h
[add] https://crrev.com/f4bc50e24731fad2ef8ac320f6347aa60fe70532/components/payments/payment_request_dialog.h

Comment 2 by ma...@chromium.org, Jan 24 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment