New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683704 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Keep showing Cookies on page navigation

Reported by craig.fr...@gmail.com, Jan 22 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36

Steps to reproduce the problem:
1. Open the Application > Cookies > Panel for the current domain.
2. Navigation to a new page.

What is the expected behavior?
The current panel should keep showing the cookies (and ideally be updated if the cookies changed).

What went wrong?
The cookies disappear, leaving a white page with the word "Cookies" in the middle. You need to re-select the domain name to view it's cookies, every time you load a new page.

Did this work before? No 

Chrome version: 58.0.2989.0  Channel: canary
OS Version: OS X 10.12.2
Flash Version: Shockwave Flash 24.0 r0

It would be nice if the primary domain name was automatically selected when you clicked on the cookies link... and maybe allow us to add/edit the cookies from here :-)
 
2017-01-22 17-29-41.png
186 KB View Download
Labels: -Type-Bug M-58 OS-Linux OS-Windows Type-Feature
Status: Untriaged (was: Unconfirmed)
This seems to be a Feature request, untriaged if it can be considered by the respective dev team.
If working on this, it's closely related to  https://crbug.com/683708  :-)
Owner: eostroukhov@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/622b9016fb49d73c33ffd3a6c9adda9b2055c09c

commit 622b9016fb49d73c33ffd3a6c9adda9b2055c09c
Author: eostroukhov <eostroukhov@chromium.org>
Date: Mon May 15 18:59:35 2017

[DevTools] Restore tree selection after reload

Application pane will now restore selection if the element is readded
within 1s after page reload and if the user does not change tree
selection by hand.

BUG= 683704 

Review-Url: https://codereview.chromium.org/2873843003
Cr-Commit-Position: refs/heads/master@{#471851}

[modify] https://crrev.com/622b9016fb49d73c33ffd3a6c9adda9b2055c09c/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[add] https://crrev.com/622b9016fb49d73c33ffd3a6c9adda9b2055c09c/third_party/WebKit/LayoutTests/http/tests/inspector/resources/resources-panel-selection-on-reload-expected.txt
[add] https://crrev.com/622b9016fb49d73c33ffd3a6c9adda9b2055c09c/third_party/WebKit/LayoutTests/http/tests/inspector/resources/resources-panel-selection-on-reload.html
[modify] https://crrev.com/622b9016fb49d73c33ffd3a6c9adda9b2055c09c/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
[modify] https://crrev.com/622b9016fb49d73c33ffd3a6c9adda9b2055c09c/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
[modify] https://crrev.com/622b9016fb49d73c33ffd3a6c9adda9b2055c09c/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js

Status: Fixed (was: Untriaged)

Comment 6 Deleted

Sorry, please ignore previous comment... was supposed to be for a different issue.

I'm assuming this has worked (was only 17 hours ago), and thank you for making this change, I really appreciate it.
Hi @eostroukhov

Thank you for making this change, I really appreciate it.

Just got a couple of odd behaviours:

1) This works on a page refresh, but doesn't when you follow a link, or submit a form. Interestingly, if I refresh the page afterwards, it restores the old selection (_willReloadPage vs _frameNavigated?).

2) If the page has no resources on it (e.g. no external CSS or JS), the list of cookies is blank (maybe the Cookie Jar is locked?).

Thanks again.
Project Member

Comment 9 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8aa8d88b844c6e9f5230d4a60a4a5b8a41e1a536

commit 8aa8d88b844c6e9f5230d4a60a4a5b8a41e1a536
Author: eostroukhov <eostroukhov@chromium.org>
Date: Wed May 24 20:56:34 2017

[DevTools] Simplify selection restoration logic

The flag is unnecessary - it is much more reliable to always attempt
restoring the selection.

BUG= 683704 

Review-Url: https://codereview.chromium.org/2897173003
Cr-Commit-Position: refs/heads/master@{#474418}

[modify] https://crrev.com/8aa8d88b844c6e9f5230d4a60a4a5b8a41e1a536/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js

Thanks again @eostroukhov,

That fixes the main issue :-)

The second one is still present, but I doubt there are many pages that have no external CSS or JS files... but if you did want to look into it, these demo URL's should show the problem:

https://www.krang.org.uk/misc/chrome/cookie-refresh/
https://www.krang.org.uk/misc/chrome/cookie-refresh/?style=true

Both set a cookie, but in Chrome 60.0.3112.0, the first one might show a flash of showing the cookie, but ultimately leaves an empty list until the user presses the cookie refresh button.

The second one (which simply references an external style sheet), seems to fix the problem (maybe due to the network delay).

Interestingly, if you delete the cookie, and refresh this second URL, the list seems to be populated twice (sometimes there is a flash of the cookies being listed, then it displays again a second later).

The attached video shows this, where the last refresh (very end of the clip, on the 3rd attempt) it shows the flicker of the cookie being shown, being hidden, and being shown again... so presumably the code used to populate the list is being run twice?

Sign in to add a comment