New issue
Advanced search Search tips

Issue 683627 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Pre-L Webapps and WebAPKs clobber each other's state

Project Member Reported by pkotw...@chromium.org, Jan 22 2017

Issue description

WebappManagedActivity#getActivityDirectory() and WebApkManagedActivity#getActivityDirectory() can return the same directory. The activity's TabState is saved to the returned directory.

This means that a WebappManagedActivity can clobber a WebApkManagedActivity's state and vice versa
 

Comment 1 Deleted

Comment 2 Deleted

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a88e6cab0f9736a8eef7fe09dfc9e3d8fdbf90f7

commit a88e6cab0f9736a8eef7fe09dfc9e3d8fdbf90f7
Author: pkotwicz <pkotwicz@chromium.org>
Date: Mon Jan 23 22:05:26 2017

WebAPK: Save TabState for WebappManagedActivities and WebApkManagedActivities in different directories

Previously, it was possible for a WebappManagedActivity to clobber a
WebApkManagedActivity's state and vice versa

BUG= 683627 

Review-Url: https://codereview.chromium.org/2648943002
Cr-Commit-Position: refs/heads/master@{#445504}

[modify] https://crrev.com/a88e6cab0f9736a8eef7fe09dfc9e3d8fdbf90f7/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkManagedActivity.java

Labels: Merge-Request-57
Requesting a merge to M-57. This CL has made it to Chrome Canary 58.0.2993.0	
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 26 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 26 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3efaa05d7f903710dd4edcd5b444ab14fe35d955

commit 3efaa05d7f903710dd4edcd5b444ab14fe35d955
Author: Peter Kotwicz <pkotwicz@google.com>
Date: Thu Jan 26 23:29:32 2017

WebAPK: Save TabState for WebappManagedActivities and WebApkManagedActivities in different directories

Previously, it was possible for a WebappManagedActivity to clobber a
WebApkManagedActivity's state and vice versa

BUG= 683627 

Review-Url: https://codereview.chromium.org/2648943002
Cr-Commit-Position: refs/heads/master@{#445504}
(cherry picked from commit a88e6cab0f9736a8eef7fe09dfc9e3d8fdbf90f7)

Review-Url: https://codereview.chromium.org/2662453003 .
Cr-Commit-Position: refs/branch-heads/2987@{#127}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/3efaa05d7f903710dd4edcd5b444ab14fe35d955/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkManagedActivity.java

Status: Fixed (was: Started)
Cc: pkotw...@chromium.org
 Issue 646608  has been merged into this issue.

Sign in to add a comment