New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683616 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 679537



Sign in to add a comment

Establish deployment procedures for Chromium Dash

Project Member Reported by amineer@chromium.org, Jan 22 2017

Issue description

We're currently deploying Chromium Dash in a semi-structured way (dev_appserver.py for deployment, pick a number for a forward version as staging, increment to prod, etc).  However, per the infrastructure PRR process, we should be using gae.py for deployment, and sergiyb@ has suggested other alternatives as well:

"""
For most of our apps we use revision-based versions. This means that when you deploy code into the app you use current revision in the repo shortened to the first 7 hex digits, e.g. version e7c0c8c should correspond to https://.../chromiumdash/+/e7c0c8c34c73a1e9e4d2ad30491a148ab48d5d2d. If you are deploying a version that is not in the repo yet, e.g. for testing modifications that you only have locally, you add -tainted suffix, e.g. e7c0c8c-tainted. There are two advantages of this approach:
It is easy to see what version has been deployed already.
It is easy to revert to an old version.
To make it easy I typically use Makefile, e.g. https://chromium.googlesource.com/infra/infra/+/master/go/src/infra/appengine/test-results/Makefile

I think for staging instances it's fine to create a custom version called to your liking, e.g. amineer-staging. For my apps, I actually use a different app for staging instances to reduce the risk of breaking production app, e.g. http://chromium-try-flakes-staging.appspot.com/
"""

Filing this bug to track discussion / implementation of a better solution.  Once established, we should update the MD describing our process.
 
Blocking: 679537
What I mentioned in quoted email is already implemented in gae.py. If we use that, then we can just call gae.py from Makefile, e.g. https://chromium.googlesource.com/infra/infra/+/master/appengine/chromium_try_flakes/Makefile
Labels: Beta-Blocking
Labels: -Beta-Blocking Stable-Blocking
Pending implementation:
 - Update MD to 'fetch infra_internal' (rather than infra-internal)
 - Figure out how we will build the Polymer code (e.g. Vulkanization)

Note all of the gae.py work is already present in infra_internal repo so we're set there.  Marking as Stable-Blocking since the bulk of the work here is done, and we can beta test the site without optimization.

Sign in to add a comment