New issue
Advanced search Search tips

Issue 683600 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

browser_side_navigation_interactive_ui_tests failing on chromium.linux/Linux Tests

Project Member Reported by wjmaclean@chromium.org, Jan 22 2017

Issue description

browser_side_navigation_interactive_ui_tests failing on chromium.linux/Linux Tests

Type: build-failure

Builders failed on: 
- Linux Tests: 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests

This appears to be another synchronization issue related to changes in

https://codereview.chromium.org/2479663002/



 
Status: Started (was: Available)
Specifically, SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands is failing due to a synchronization issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8842cfaaca883d5f7b88504f4639e86f1368995

commit a8842cfaaca883d5f7b88504f4639e86f1368995
Author: wjmaclean <wjmaclean@chromium.org>
Date: Sun Jan 22 01:07:05 2017

Fix synchronization in SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands.

Keyboard events in some tests have been assumed to be synchronous
with ExecuteScript commands, but that assumption is no longer
valid with OOPIFs getting their own InputHandlers in
https://codereview.chromium.org/2479663002/.

TBR=creis@chromium.org

BUG= 683600 

Review-Url: https://codereview.chromium.org/2645203002
Cr-Commit-Position: refs/heads/master@{#445296}

[modify] https://crrev.com/a8842cfaaca883d5f7b88504f4639e86f1368995/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

Status: Fixed (was: Started)
This seems to have cleared the failure.
Just to add some more documentation, the test was failing on:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests

Sign in to add a comment