New issue
Advanced search Search tips

Issue 683532 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Keyboard shortcuts are broken in DevTools Console

Reported by ckm...@gmail.com, Jan 21 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36

Steps to reproduce the problem:
1. Open DevTools -> Console
2. Start typing some Javascript into the console.
3. Try to use ctrl+f/ctrl+b/alt+b/alt+f/ctrl+k/ctrl+h to move around.

Most of these shortcuts are broken or work in a very inconsistent manner. When first starting to type out a line, ctrl+h will work, but not alt+b/f nor ctrl+f/b. As soon as the line is finished or becomes a valid chunk of Javascript, ctrl+h stops working.

I have to point out that the usual arrow keys/backspace do work as intended. To give you an idea of how my keyboard
is configured, here's my DefaultKeyBinding.dict file located under ~/Library/KeyBindings/.

{
/* Remap Home / End to be correct */
"\UF729"  = "moveToBeginningOfLine:";                   /* Home         */
"\UF72B"  = "moveToEndOfLine:";                         /* End          */
"$\UF729" = "moveToBeginningOfLineAndModifySelection:"; /* Shift + Home */
"$\UF72B" = "moveToEndOfLineAndModifySelection:";       /* Shift + End  */
"~f"="moveWordForward:";
"~b"="moveWordBackward:";
"~<"="moveToBeginningOfDocument:";
"~>"="moveToEndOfDocument:";
"~v"="pageUp:";
"~d"="deleteWordForward:";
"~^h"="deleteWordBackward:";
"~\010"="deleteWordBackward:"; /* Alt-backspace */
"~\177"="deleteWordForward:"; /* Alt-delete */
} 

These bindings are on OS level and work correctly in every application running on the machine. All bindings worked correctly in the DevTools Console up until around Chrome 54/55.

What is the expected behavior?
All OS configured shortcuts should work as intended.

What went wrong?
Upgraded Chrome to latest version.

Did this work before? Yes ~53/54

Chrome version: 55.0.2883.95  Channel: stable
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 24.0 r0
 
Labels: ReleaseBlock-Stable M-56
Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks for the report, it has been fixed in latest Dev 57.0.2986.0 & canary 58.0.2990.0.
Able to reproduce the issue on Mac 10.12.2 using 55.0.2883.95 and 56.0.2924.67.

Reverse Bisect info:
====================
Bad: 57.0.2946.0
Good:57.0.2947.0

You are probably looking for a change made after 437456 (known good), but no later than 437457 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/c2ff63fad7483656ea28d0d9e35267add5fd29f6..247b2e4c45b9e2504c54a0725f39df52d8c071b2

einbinder@: Could you please check if it can be merged back to M56 & M55.
Added Releaseblock-stable if it can be merged to M56 before M56 stable push.

Note: Not applicable to Win and Linux.

Comment 2 by ckm...@gmail.com, Jan 25 2017

Update: 
I've installed Chrome Dev 57.0.2987.8 dev (64-bit) to try out the patch that Durga linked.

Everything worked except for 2 bindings, Alt+b and Alt+f. Those were originally bound to 'goGroupLeft' and 'goGroupRight' respectively, but have now been rebound to Ctrl+Alt+b/f. 

Excerpt from the diff:
+      'Ctrl-Alt-B': 'goGroupLeft',
+      'Ctrl-Alt-F': 'goGroupRight',

Would it be possible to restore the old behaviour, or at least have them co-exist? 

ckm2k1@ Thanks so much for the update.

Would you mind logging another issue for - Alt+b and Alt+f.
Labels: -M-56 M-57
Requesting M57 owners to log an issue for fixing Alt+b and Alt+f.

Comment 5 by ckm...@gmail.com, Feb 4 2017

Opened issue for Alt+b/Alt+f here: https://bugs.chromium.org/p/chromium/issues/detail?id=688728
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Comment 7 by ckm...@gmail.com, Feb 10 2017

Hey Chrome folks, 

Is there any chance this'll make it into M57? It's sorely missed as we work with DevTools day in and day out. 

Thanks!
einbinder@ Since this issue is marked as RB-Stable can we get any latest update on this issue? we're getting closer to M57 early stable launch.

Thanks!

Comment 9 by gov...@chromium.org, Feb 16 2017

A friendly reminder that M57 Stable is launch is coming VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

URGENT - PTAL ASAP.

We're getting VERY close to M57 Stable promotion. And 
this issue is marked as M57 stable release blocker. Pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion).

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M58.

Thank you.
Cc: pbomm...@chromium.org gov...@chromium.org
This is working fine now on Mac 10.12.3 using latest beta # 57.0.2987.74 except the issue mentioned under comment # 2 and is tracked under  Issue 688728 .

Krishna/Prudhvi: Could you please take a look and update if the blocker still required.
Labels: -ReleaseBlock-Stable
Status: Archived (was: Assigned)
Bulk closing low-priority issues with no activity. Please re-file and refer to the closed issue if it's essential to fix.

Sign in to add a comment