New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683456 link

Starred by 14 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Device doesn't maintain orientation lock when windows opened

Reported by james.cr...@gmail.com, Jan 21 2017

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS armv7l 9000.66.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.67 Safari/537.36
Platform: 9000.66.0 (Official Build) beta-channel veyron_minnie

Steps to reproduce the problem:
* Open Chrome and go to a website. Go into tablet/portrait mode. 
* Enable orientation lock.
* An icon will appear in your status bar at the bottom of the screen showing that orientation lock is on.
* Open any app that spawns a new window. [Examples might be: an Android app; a web shortcut marked "open as window".]
* The icon will disappear and orientation lock will be deactivated.

What is the expected behavior?
It should stay locked.

Specifically, in tablet mode, I would expect it to respect the last value of the orientation lock toggle, and the last value of the desired orientation. It shouldn't come out of orientation lock in tablet mode, ever, unless it is user-requested.

What went wrong?
The orientation lock is deselected if a new window is opened, and orientation is no longer locked.

Did this work before? No 

Chrome version: 56.0.2924.67  Channel: beta
OS Version: 9000.66.0
Flash Version: Shockwave Flash 24.0 r0
 
Notes:

This is not the same as https://bugs.chromium.org/p/chromium/issues/detail?id=533888 which is related to sensors on the device. Orientation lock is rock solid as long as you don't open any new windows.

A locked thread on this topic - https://productforums.google.com/forum/#!topic/chromebook-central/wFZ5Ovy2BgA;context-place=topicsearchin/chromebook-central/orientation$20lock - linked to a bug https://bugs.chromium.org/p/chromium/issues/detail?id=120680 which was shipped in M54. I am confused about  bug 120680 's relevance to this fault.
Owner: omrilio@chromium.org
Status: Assigned (was: Unconfirmed)
To omrilio for touchview.
Confirmed still not working in the following beta build

Version 56.0.2924.79 beta
Platform 9000.76.0 (Official Build) beta-channel veyron_minnie
ARC Version 3674649
Firmware Google_Veyron_Minnie.6588.237.0
Confirmed still not working in the following beta build

Version 56.0.2924.87 beta
Platform 9000.82.0 (Official Build) beta-channel veyron_minnie
ARC Version 3691121
Firmware Google_Veyron_Minnie.6588.237.0

Here is a video, showing this build, with the rotation lock failing. Apps opened are the Google Keep Chrome app, the Minimalist Markdown Editor, and a pinned 'open as new window' bookmark. https://www.youtube.com/watch?v=mjRdoNNUi3M
Cc: omrilio@chromium.org
Components: -UI UI>Shell>TouchView
Labels: -Pri-2 Pri-1
Owner: osh...@chromium.org
Thanks for the video, this is bad.
Oshima, can you have a look into this?

Comment 6 by dymp...@gmail.com, Feb 4 2017

I can confirm the behavior on my Flip on Stable 55.

Version 55.0.2883.105
Platform 8872.76.0 (Official Build) stable-channel veyron_minnie
ARC Version 3617689
Firmware Google_Veyron_Minnie.6588.197.0

#CBC-RS/TC-watchlist 


Cc: jonr...@chromium.org

Comment 8 by osh...@chromium.org, Feb 13 2017

This is currently WAI, but I agree that this needs to be changed. (There is a ARC++ side bug b/32299181)

I'll work on a simple doc, and hopefully can send it soon.
There is a change of behaviour in the latest beta.

The rotation lock is now maintained if you open a new Chrome window. Hurray!
It is still lost if you open a new Android window. Boo.

This is a significant step forward, since I can now flick between Chrome apps and Chrome windows without rotation lock being lost. Thank you for your help so far.

Version 57.0.2987.32 beta
Platform 9202.18.0 (Official Build) beta-channel veyron_minnie
ARC Version 3704776
Firmware Google_Veyron_Minnie.6588.237.0
Slightly strangely, my system has just told me to do another update, even though these numbers remain the same.

Rotation is still lost if you open a new Android window.

Version 57.0.2987.32 beta
Platform 9202.18.0 (Official Build) beta-channel veyron_minnie
ARC Version 3704776
Firmware Google_Veyron_Minnie.6588.237.0
Similar, but not exactly. Perhaps just another symptom of the problem. My problems seem to be limited to the newstand: 

Version 56.0.2924.87 beta
Platform 9000.82.0 (Official Build) beta-channel veyron_minnie
ARC Version 3691121
Firmware Google_Veyron_Minnie.6588.237.0

I use it most of the time as a chromebook, but I can flip the screen and
use it as an Android tablet.   Most apps work well, but something happened
recently with Google Play Newstand 4.1.0.  If I start up the Newstand in 
portrait mode and then open an article, the article does not open full size,
but only to the width of the screen.   Also, if I have the tablet in portrait,
and open up the Newstand, it will also only be the width of the screen. 
If I subsequently rotate the tablet to landscape, it goes full screen, only
to be limited to width of screen when I return to portrait.

I can confirm that I see the behavior the original poster sees as well. 




Confirmed on Samsung Chromebook Pro. We need working orientation lock. For instance, if I'm using the android Youtube app and cast something, clicking on the cast button in the notification section of chromeOS immediately takes away the orientation lock.
 
Version 56.0.2924.104 beta
Platform 9000.87.1 (Official Build) beta-channel kevin
ARC Version 3741569
Firmware Google_Kevin.8785.149.0
i can confirm orientation lock does does not stay active on my acer r13
Confirmation that orientation lock fails with the latest beta channel build.

As above, orientation lock fails when opening an Android application while within a Chrome window.

Version 57.0.2987.85 beta
Platform 9202.43.0 (Official Build) beta-channel veyron_minnie
ARC Version 3768718
Firmware Google_Veyron_Minnie.6588.237.0
Thanks everyone for the feedback. We are aware that the orientation lock fails when used in conjunction with Android applications.

Work is being done to address this, and we'll update this bug once a fix is available.
Status: Started (was: Assigned)
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5176fd790a6ccc800274a4135dbdc7476deac88

commit a5176fd790a6ccc800274a4135dbdc7476deac88
Author: oshima <oshima@chromium.org>
Date: Fri Mar 24 00:09:05 2017

User orientation lock

* Added user locked orientation.
  Once it's locked, the orientation will be used as a preferred orientation.
   - If the active appilcation's orientation is any, the user locked orientation will be used.
   - If the active appilcation's orientation is specified, the user locked orientation will be ignored
     and uses the application's orientation.
* Exclude windows that does not have AppType because they do not control orientation into account.
  For example, task manager, app list shouldn't affect orientation.
* added ScreenOrientationControllerTestApi

Next steps:
  - landscape / portrait app should lock to secondary/primary.
  - remember and restore the locked state.
  - handle rotation change from chrome.system.display api.
  - Add portrait/landscape lock icon and make UI consistent with Android rotation lock UI.

BUG= 683456 
TEST=manual, unitt tests

Review-Url: https://codereview.chromium.org/2757493002
Cr-Commit-Position: refs/heads/master@{#459291}

[modify] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/ash/content/display/screen_orientation_controller_chromeos_unittest.cc
[modify] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/ash/display/screen_orientation_controller_chromeos.h
[modify] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/ash/system/chromeos/rotation/tray_rotation_lock.cc
[modify] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/ash/system/chromeos/rotation/tray_rotation_lock.h
[modify] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/ash/test/BUILD.gn
[modify] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/ash/test/DEPS
[add] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/ash/test/screen_orientation_controller_test_api.cc
[add] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/ash/test/screen_orientation_controller_test_api.h
[modify] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/chrome/browser/chromeos/display/display_preferences_unittest.cc
[modify] https://crrev.com/a5176fd790a6ccc800274a4135dbdc7476deac88/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc

Labels: ReleaseBlock-Stable Merge-Request-58 M-58
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28bd8173b80ae1fe5e22875580051664cd97363d

commit 28bd8173b80ae1fe5e22875580051664cd97363d
Author: oshima <oshima@chromium.org>
Date: Fri Mar 24 19:00:26 2017

Remember User locked rotation

* Save when the toggle state changes, as that's
 only time the value changes.
* implement reverse lock.

BUG= 695281 ,  683456 
TEST=manual, covered by unit test

Review-Url: https://codereview.chromium.org/2773013003
Cr-Commit-Position: refs/heads/master@{#459502}

[modify] https://crrev.com/28bd8173b80ae1fe5e22875580051664cd97363d/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/28bd8173b80ae1fe5e22875580051664cd97363d/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/28bd8173b80ae1fe5e22875580051664cd97363d/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc

Project Member

Comment 20 by sheriffbot@chromium.org, Mar 25 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: bhthompson@chromium.org
+bhthompson@

This is chromeos only change that is necessary for arc: b/32299181
Labels: -Hotlist-Merge-Review -Merge-Review-58 Merge-Approved-58
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 27 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ff47417a996e5b5afd777dc385809d6372d42b2

commit 3ff47417a996e5b5afd777dc385809d6372d42b2
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Mar 27 19:14:31 2017

User orientation lock

* Added user locked orientation.
  Once it's locked, the orientation will be used as a preferred orientation.
   - If the active appilcation's orientation is any, the user locked orientation will be used.
   - If the active appilcation's orientation is specified, the user locked orientation will be ignored
     and uses the application's orientation.
* Exclude windows that does not have AppType because they do not control orientation into account.
  For example, task manager, app list shouldn't affect orientation.
* added ScreenOrientationControllerTestApi

Next steps:
  - landscape / portrait app should lock to secondary/primary.
  - remember and restore the locked state.
  - handle rotation change from chrome.system.display api.
  - Add portrait/landscape lock icon and make UI consistent with Android rotation lock UI.

BUG= 683456 
TEST=manual, unitt tests

Review-Url: https://codereview.chromium.org/2757493002
Cr-Commit-Position: refs/heads/master@{#459291}
(cherry picked from commit a5176fd790a6ccc800274a4135dbdc7476deac88)
(cherry picked from commit a85beb49b1025a0430f5886c60b4d8768ef66352)

Review-Url: https://codereview.chromium.org/2776283002 .
Cr-Commit-Position: refs/branch-heads/3029@{#436}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/ash/content/display/screen_orientation_controller_chromeos_unittest.cc
[modify] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/ash/display/screen_orientation_controller_chromeos.h
[modify] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/ash/system/chromeos/rotation/tray_rotation_lock.cc
[modify] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/ash/system/chromeos/rotation/tray_rotation_lock.h
[modify] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/ash/test/BUILD.gn
[modify] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/ash/test/DEPS
[add] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/ash/test/screen_orientation_controller_test_api.cc
[add] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/ash/test/screen_orientation_controller_test_api.h
[modify] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/chrome/browser/chromeos/display/display_preferences_unittest.cc
[modify] https://crrev.com/3ff47417a996e5b5afd777dc385809d6372d42b2/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc

Status: Fixed (was: Started)
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18462f6c9998579452ba3f6531170f8bb14f38c1

commit 18462f6c9998579452ba3f6531170f8bb14f38c1
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Mar 27 19:35:09 2017

Remember User locked rotation

* Save when the toggle state changes, as that's
 only time the value changes.
* implement reverse lock.

BUG= 695281 ,  683456 
TEST=manual, covered by unit test

Review-Url: https://codereview.chromium.org/2773013003
Cr-Commit-Position: refs/heads/master@{#459502}
(cherry picked from commit 28bd8173b80ae1fe5e22875580051664cd97363d)
(cherry picked from commit ffb46dd77d7c4702110bf9dd6f3a9d35f70b41e5)

Review-Url: https://codereview.chromium.org/2777163003 .
Cr-Commit-Position: refs/branch-heads/3029@{#437}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/18462f6c9998579452ba3f6531170f8bb14f38c1/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/18462f6c9998579452ba3f6531170f8bb14f38c1/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/18462f6c9998579452ba3f6531170f8bb14f38c1/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc

Hmmm.  This seemed to be fixed for a while, and now again is broken on ASUS Flip. 

Version 58.0.3029.31 beta
Platform 9334.18.0 (Official Build) beta-channel veyron_minnie
ARC Version 3836087
Firmware Google_Veyron_Minnie.6588.237.0
Check for and apply updates


My test:  
- in laptop mode (hw keyboard enabled) bring up google play newsstand (android app)
- fold keyboard back 
- make orientation landscape
- click on any article
- new window comes up in landscape, spanning width of portrait but height limited to whatever that ratio is
- rotate back to landscape, window is fine

Rotation lock is reset after every new window. 

Chrome itself is not affected. 

Problem affects Android apps like Google Play, BBC, NY Times.  It does not affect some apps like Adobe Draw or Sketch. 




Status: Fixed (was: Started)
The chromeos orientation lock semantics was different from Android, so it never worked in the way you'd expect on Android. This is now fixed.
Status: Verified (was: Fixed)
verified on 59.0.3064.0 / 9438.0.0 build
My Samsung Chromebook Plus will not rotate at all. This has occurred twice after changing from the stable to beta trying to get the Sonos app to work.  It worked after the first powerwash but rotation failed to work.  Neither work after the second power wash.  This is annoying to say the least
rotate.png
300 KB View Download
#29 I'm not aware of if changes between the branches would affect your sensors. Can you try to reset the EC? (Power+Refresh)

If you are still having issues with no rotation working please file a new bug. This bug was to track that Android apps were not working with rotation lock. Your device not having sensor information is a different issue.
Maybe  crbug.com/718145 ?

Sign in to add a comment