New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 683450 link

Starred by 1 user
Status: WontFix
Owner:
█ dshi@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
akes...@chromium.org
dgarr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

CQ should not pick up CL doesn't pass trybot

Project Member Reported by dshi@chromium.org, Jan 21 2017 
https://chromium-review.googlesource.com/#/c/426799/

The change failed try-bot several times, however, when the CL got CQ +1, CQ still picks up the CL.

The failed CQ runs woundn't be affected by this CL if we force the trybot pass.

Comment 1 by dshi@chromium.org, Jan 23 2017

Cc: akes...@chromium.org dgarr...@chromium.org
+Aviv, Don

Can any of you comment if I have any misunderstanding here?

Comment 2 by akes...@chromium.org, Jan 23 2017 

As far as I see, this CL passed the pre-cq.

Which patch set got picked up by cq without passing pre-cq?

Comment 3 by pprabhu@chromium.org, Jan 25 2017

Labels: -current-issue
Owner: dshi@chromium.org
Status: Assigned (was: Untriaged)
I don't see anything fishy there either. Dan, please explain / close.

Comment 4 by dshi@chromium.org, Jan 25 2017

Status: WontFix (was: Assigned)
Seems I was confused by the pre-submit test and cq runs in between several patchsets.
►

Sign in to add a comment