New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683438 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Focus rectangle is broken on Launcher icon

Project Member Reported by sdantul...@chromium.org, Jan 21 2017

Issue description

Google Chrome	57.0.2984.0 (Official Build) dev (64-bit)
Revision	0
Platform	9202.0.0 (Official Build) dev-channel link

What steps will reproduce the problem?
1. Click Alt + Shift + L
2. Observe focus around launcher icon

What happens instead?
Focus rectangle is not aligned properly

Attached screenshot.

 
Screenshot 2017-01-20 at 4.41.19 PM.png
95.7 KB View Download
Owner: est...@chromium.org
sdantuluri@, can you verify whether or not you have the "ash-md" flag in about:flags set to 'Default' or not?

FTR I cannot reproduce this issue in the latest canary (57.0.2984.0) or in the latest beta (56.0.2924.67). The report in #0 is from dev-channel so it is possible that this was fixed very recently and has not yet made it into dev.

Assigning to estade as FYI / for any further thoughts / to mark as WontFix if my above assumption is correct.
Verified that "ash-md" flag is set to Default
I am seeing this issue on link and samus. Not seeing this on minnie device with same build.

Comment 4 by est...@chromium.org, Jan 23 2017

Cc: bruthig@chromium.org est...@chromium.org
Owner: glevin@chromium.org
I think it was Greg who fixed this recently?

Comment 5 by glevin@chromium.org, Jan 24 2017

I fixed the positioning of the SysTray rectangle for  Issue 672723 , but I don't think the two are related.  The SysTray is handled in Views, but the rest of the shelf is web-based.  I'm out this week ad maybe next, but can look at it when I get back, if it'll keep till then.

Comment 6 by est...@chromium.org, Jan 24 2017

I don't think the rest of the shelf is web based, that's only true of login. This button is app_list_button.cc

The last change I can find was in late November so I'm a little worried that there's some variable we aren't accounting for here, i.e. the bug is real but the repro steps are incomplete.
Status: Assigned (was: Untriaged)
Owner: x...@chromium.org
glevin is OOO for a while. xdai@can you take a look?
sdantuluri@, regarding comment #6, can you confirm that your repro steps are complete (e.g., you don't have any UI zoom applied, ChromeVox is not enabled, etc)?

xdai@, as per #3, given this reproduces on link/samus but not on minnie, it's possible that it depends on the device scale factor (which for the former is 2).
tdanderson@ Repro steps are complete.

I retested on powerwashed link device with 9202.1.0, 57.0.2987.6 dev build
Labels: -Pri-2 ReleaseBlock-Stable Pri-1

Comment 13 by x...@chromium.org, Feb 1 2017

Status: Fixed (was: Assigned)
CL was landed.

Comment 14 by x...@chromium.org, Feb 1 2017

Labels: Merge-Request-57
Status: Started (was: Fixed)
Leaving this as Started until the merge back to m-57 has been completed.
Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 Chrome OS.
Project Member

Comment 17 by sheriffbot@chromium.org, Feb 6 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 6 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d85f1b8d2b0394573b1d403b24be506f9599081

commit 2d85f1b8d2b0394573b1d403b24be506f9599081
Author: xdai <xdai@chromium.org>
Date: Mon Feb 06 18:55:58 2017

[Merge to M57][Chrome OS] Fix the broken focus rectangle on Launcher icon.

BUG= 683438 
TEST=manually
TBR=oshima@chromium.org, estade@chromium.org

Review-Url: https://codereview.chromium.org/2661163003
Cr-Commit-Position: refs/heads/master@{#447445}
(cherry picked from commit 58116ee5b2710dd751d968024489b305ae18b038)

Review-Url: https://codereview.chromium.org/2674743005 .
Cr-Commit-Position: refs/branch-heads/2987@{#337}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/2d85f1b8d2b0394573b1d403b24be506f9599081/ash/common/shelf/app_list_button.cc

Comment 19 by x...@chromium.org, Feb 6 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9202.22.0 / 57.0.2987.35

Sign in to add a comment