Issue metadata
Sign in to add a comment
|
Focus rectangle is broken on Launcher icon |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 57.0.2984.0 (Official Build) dev (64-bit) Revision 0 Platform 9202.0.0 (Official Build) dev-channel link What steps will reproduce the problem? 1. Click Alt + Shift + L 2. Observe focus around launcher icon What happens instead? Focus rectangle is not aligned properly Attached screenshot.
,
Jan 23 2017
Verified that "ash-md" flag is set to Default
,
Jan 23 2017
I am seeing this issue on link and samus. Not seeing this on minnie device with same build.
,
Jan 23 2017
I think it was Greg who fixed this recently?
,
Jan 24 2017
I fixed the positioning of the SysTray rectangle for Issue 672723 , but I don't think the two are related. The SysTray is handled in Views, but the rest of the shelf is web-based. I'm out this week ad maybe next, but can look at it when I get back, if it'll keep till then.
,
Jan 24 2017
I don't think the rest of the shelf is web based, that's only true of login. This button is app_list_button.cc The last change I can find was in late November so I'm a little worried that there's some variable we aren't accounting for here, i.e. the bug is real but the repro steps are incomplete.
,
Jan 24 2017
,
Jan 24 2017
glevin is OOO for a while. xdai@can you take a look?
,
Jan 24 2017
sdantuluri@, regarding comment #6, can you confirm that your repro steps are complete (e.g., you don't have any UI zoom applied, ChromeVox is not enabled, etc)? xdai@, as per #3, given this reproduces on link/samus but not on minnie, it's possible that it depends on the device scale factor (which for the former is 2).
,
Jan 24 2017
tdanderson@ Repro steps are complete. I retested on powerwashed link device with 9202.1.0, 57.0.2987.6 dev build
,
Jan 28 2017
,
Feb 1 2017
CL in review: https://codereview.chromium.org/2661163003/
,
Feb 1 2017
CL was landed.
,
Feb 1 2017
,
Feb 1 2017
Leaving this as Started until the merge back to m-57 has been completed.
,
Feb 2 2017
Approving merge to M57 Chrome OS.
,
Feb 6 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d85f1b8d2b0394573b1d403b24be506f9599081 commit 2d85f1b8d2b0394573b1d403b24be506f9599081 Author: xdai <xdai@chromium.org> Date: Mon Feb 06 18:55:58 2017 [Merge to M57][Chrome OS] Fix the broken focus rectangle on Launcher icon. BUG= 683438 TEST=manually TBR=oshima@chromium.org, estade@chromium.org Review-Url: https://codereview.chromium.org/2661163003 Cr-Commit-Position: refs/heads/master@{#447445} (cherry picked from commit 58116ee5b2710dd751d968024489b305ae18b038) Review-Url: https://codereview.chromium.org/2674743005 . Cr-Commit-Position: refs/branch-heads/2987@{#337} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/2d85f1b8d2b0394573b1d403b24be506f9599081/ash/common/shelf/app_list_button.cc
,
Feb 6 2017
,
Feb 10 2017
9202.22.0 / 57.0.2987.35 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tdander...@chromium.org
, Jan 23 2017