New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 683432 link

Starred by 1 user
Status: Fixed
Owner:
█ baxley@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Make custom EarlGrey actions match Chromium style

Project Member Reported by baxley@chromium.org, Jan 21 2017 
Custom EarlGrey actions are consistent with EarlGrey, which are C-style methods that start with a lowercase letter. For example:
webViewVerifiedActionOnElement in web_view_actions.mm/h

These should match Chromium style.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e07705dc86eaaf8473e7e9727a0817db46f40d22

commit e07705dc86eaaf8473e7e9727a0817db46f40d22
Author: baxley <baxley@chromium.org>
Date: Fri Mar 24 17:04:15 2017

Make custom GREYAction methods Chromium C-Style.

These methods are C-Style, so they should start with a capital
letter.

BUG= 683432 

Review-Url: https://codereview.chromium.org/2777463002
Cr-Commit-Position: refs/heads/master@{#459462}

[modify] https://crrev.com/e07705dc86eaaf8473e7e9727a0817db46f40d22/ios/chrome/browser/autofill/form_input_egtest.mm
[modify] https://crrev.com/e07705dc86eaaf8473e7e9727a0817db46f40d22/ios/chrome/browser/context_menu/context_menu_egtest.mm
[modify] https://crrev.com/e07705dc86eaaf8473e7e9727a0817db46f40d22/ios/chrome/browser/ui/settings/block_popups_egtest.mm
[modify] https://crrev.com/e07705dc86eaaf8473e7e9727a0817db46f40d22/ios/chrome/browser/web/browsing_egtest.mm
[modify] https://crrev.com/e07705dc86eaaf8473e7e9727a0817db46f40d22/ios/chrome/test/earl_grey/chrome_actions.h
[modify] https://crrev.com/e07705dc86eaaf8473e7e9727a0817db46f40d22/ios/chrome/test/earl_grey/chrome_actions.mm
[modify] https://crrev.com/e07705dc86eaaf8473e7e9727a0817db46f40d22/ios/web/public/test/earl_grey/web_view_actions.h
[modify] https://crrev.com/e07705dc86eaaf8473e7e9727a0817db46f40d22/ios/web/public/test/earl_grey/web_view_actions.mm
[modify] https://crrev.com/e07705dc86eaaf8473e7e9727a0817db46f40d22/ios/web/shell/test/context_menu_egtest.mm
[modify] https://crrev.com/e07705dc86eaaf8473e7e9727a0817db46f40d22/ios/web/shell/test/earl_grey/shell_actions.h
[modify] https://crrev.com/e07705dc86eaaf8473e7e9727a0817db46f40d22/ios/web/shell/test/earl_grey/shell_actions.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f2a256cb3ccc0be76c80d2cddde524cd2b5e7cb

commit 8f2a256cb3ccc0be76c80d2cddde524cd2b5e7cb
Author: baxley <baxley@chromium.org>
Date: Sat Mar 25 00:42:47 2017

Delete non-Chromium style custom GREYAction.

longPressElementForContextMenu has been replaced with
LongPressElementForContextMenu.

BUG= 683432 

Review-Url: https://codereview.chromium.org/2772113003
Cr-Commit-Position: refs/heads/master@{#459606}

[modify] https://crrev.com/8f2a256cb3ccc0be76c80d2cddde524cd2b5e7cb/ios/chrome/test/earl_grey/chrome_actions.h
[modify] https://crrev.com/8f2a256cb3ccc0be76c80d2cddde524cd2b5e7cb/ios/chrome/test/earl_grey/chrome_actions.mm

Comment 3 by baxley@chromium.org, Mar 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment