New issue
Advanced search Search tips

Issue 683414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

PDF find-in-page selects all the text on a page for the search result at the end of the page

Project Member Reported by thestig@chromium.org, Jan 21 2017

Issue description

Chrome Version: 55, 57, all previous versions?
OS: Linux, likely all

What steps will reproduce the problem?
(1) Open https://www.fueleconomy.gov/feg/pdfs/guides/FEG2017.pdf
(2) Search for: " ss" without the quotes
(3) Repeatedly go to the next search result until the 11th result, which is the letters " SS" on the end of the 8th page for the F-Type R AWD Convertible.

What is the expected result?

The letters " SS" are highlighted

What happens instead?

All the text on the 8th page, except for " SS" gets highlighted.
 
Components: UI>Browser>FindInPage

Comment 2 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ed6d4447aba42525fc8a0020320325542925049

commit 3ed6d4447aba42525fc8a0020320325542925049
Author: thestig <thestig@chromium.org>
Date: Tue Jan 24 14:29:49 2017

PDF: Fix a failing find-in-page corner case.

When the result is the text at the end of a page, the text highlight for
the search result is incorrect.

BUG= 683414 

Review-Url: https://codereview.chromium.org/2645813007
Cr-Commit-Position: refs/heads/master@{#445718}

[modify] https://crrev.com/3ed6d4447aba42525fc8a0020320325542925049/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/3ed6d4447aba42525fc8a0020320325542925049/pdf/pdfium/pdfium_engine.h

Status: Fixed (was: Assigned)

Sign in to add a comment