New issue
Advanced search Search tips

Issue 683396 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-01-20
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility


Sign in to add a comment

ChromeVox should support ARC++ "natively"

Project Member Reported by dtseng@chromium.org, Jan 20 2017

Issue description

Feature tracking bug
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f

commit be42343c9fd8b9fbb5733faf2e93abc3ff648b7f
Author: dtseng <dtseng@chromium.org>
Date: Wed Feb 22 14:05:43 2017

Initial support for native accessibility in ARC

This is an initial implementation of native ARC++ accessibility.

An accessibility tree is forwarded to Chrome and Chrome forwards tree data to extensions.

TEST=manual
- in ChromeVox, in a js-background page context, verify the contents of the accessibility tree from ARC show up; when events occur, verify events are received; when the ARC+++ surface is deactivated, verify tree gets destroyed/deatched
- touch explore with ChromeVox; verify basic speech feedback
- ChromeVox object navigation works

BUG=683396
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2640123004
Cr-Commit-Position: refs/heads/master@{#452029}

[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/chrome/browser/chromeos/arc/accessibility/OWNERS
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
[add] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[add] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.h
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/chrome/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/chromeos/chromeos_switches.cc
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/chromeos/chromeos_switches.h
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/components/arc/common/accessibility_helper.mojom
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/content/browser/BUILD.gn
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/content/browser/accessibility/ax_platform_position.h
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/content/browser/accessibility/browser_accessibility_manager.cc
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/content/browser/accessibility/browser_accessibility_manager.h
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/ui/accessibility/BUILD.gn
[rename] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/ui/accessibility/ax_tree_id_registry.cc
[rename] https://crrev.com/be42343c9fd8b9fbb5733faf2e93abc3ff648b7f/ui/accessibility/ax_tree_id_registry.h

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32ea1736ed52553710e6002a63c9ab0ea75261aa

commit 32ea1736ed52553710e6002a63c9ab0ea75261aa
Author: dtseng <dtseng@chromium.org>
Date: Sat Feb 25 00:52:27 2017

Initial support for accessibility actions on ARC.

BUG=683396
TEST=with ChromeVox on, Search+space while within ARC; verify click propagates to ARC and the node gets clicked.

Review-Url: https://codereview.chromium.org/2700103004
Cr-Commit-Position: refs/heads/master@{#453028}

[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.h
[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/chrome/browser/extensions/BUILD.gn
[delete] https://crrev.com/5dcf3589e69f5511ded5a0180da2ddb00db23234/chrome/browser/extensions/api/automation_internal/automation_action_adapter.h
[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/chrome/browser/extensions/api/automation_internal/automation_internal_api.h
[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/chrome/browser/ui/aura/accessibility/automation_manager_aura.h
[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/ui/accessibility/BUILD.gn
[add] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/ui/accessibility/ax_host_delegate.cc
[add] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/ui/accessibility/ax_host_delegate.h
[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/ui/accessibility/ax_tree_id_registry.cc
[modify] https://crrev.com/32ea1736ed52553710e6002a63c9ab0ea75261aa/ui/accessibility/ax_tree_id_registry.h

Labels: OS-Chrome
Labels: NewComponent-Accessibility-ChromeVox
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d36c05b57d332e75f5e01a43bde92ed55ad54ba5

commit d36c05b57d332e75f5e01a43bde92ed55ad54ba5
Author: dtseng <dtseng@chromium.org>
Date: Thu Mar 23 19:48:10 2017

Enable native accessible touch support inside of ARC

TEST=manual. With the --enable-chromevox-arc-support flag set on, touch explore within a shell surface and across to the shelf. Observe proper spoken feedback. Additionally, use multi finger gestures and observe proper dispatch of events to ChromeVox e.g. one finger swipe moves linearly.

Without the flag, do the same and observe Talkback spoken feedback within shell surface and ChromeVox feedback on shelf.
BUG=683396

Review-Url: https://codereview.chromium.org/2746543004
Cr-Commit-Position: refs/heads/master@{#459185}

[modify] https://crrev.com/d36c05b57d332e75f5e01a43bde92ed55ad54ba5/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/d36c05b57d332e75f5e01a43bde92ed55ad54ba5/ash/ash_touch_exploration_manager_chromeos.h
[modify] https://crrev.com/d36c05b57d332e75f5e01a43bde92ed55ad54ba5/components/exo/pointer.cc

Labels: NewComponent-Accessibility
Components: UI>Accessibility>ChromeVox
Labels: -newcomponent-accessibility -newcomponent-accessibility-chromevox
Components: -UI>Accessibility
Blockedon: 702659
Blockedon: 708272
Blockedon: 702670
Blockedon: 702668
Blockedon: 702666
Blockedon: 702664
Blockedon: 702663
Blockedon: 702660
Blockedon: 702654
Labels: arc-a11y
 Issue 849093  has been merged into this issue.

Sign in to add a comment