Document (or disable?) subsystem based board-aware submission logic. |
||||||||||||||
Issue descriptionThe new 'subsystem' field in COMMIT-QUEUE.ini introduced via https://chromium-review.googlesource.com/#/c/313740/ is undocumented. Please add documentation here: https://sites.google.com/a/chromium.org/dev/chromium-os/build/bypassing-tests-on-a-per-project-basis Also, I couldn't find any users of this feature. The only subsystem tags I found were all saying subsystem:all (http://shortn/_2FxQhYeRvD) What gives?
,
Mar 31 2018
It might be time to disable this feature. No real users, and will be supplanted by Test Planner.
,
Apr 1 2018
Good starter bug. Holding this for a new team member.
,
Jul 2
Hi Dhanya, Please take a look at this. Should be pretty straight-forward to disable this feature.
,
Jul 2
AFAI understand, the original CL generates the set of failing and passing subsystems using CIDB queries in GetSubsysResultForSlaves. This is later used in _CanIgnoreFailures to make sure that all the subsystems listed in COMMIT-QUEUE.ini are passing. It looks like https://cs.corp.google.com/chromeos_public/src/third_party/chromiumos-overlay/chromeos-base/shill/COMMIT-QUEUE.ini?q=file:COMMIT-QUEUE.ini+subsystem&sq=package:chromeos&dr=C&l=9 is the only one that's not testing for all subsystems.
,
Jul 3
Okay this looks safe to remove, then. Let's start by removing all the COMMIT-QUEUE.ini references to this feature completely.
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/db0ecad3897c96c13bcaaf6f37dadb6bf0e3ec7f commit db0ecad3897c96c13bcaaf6f37dadb6bf0e3ec7f Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Tue Jul 03 20:28:59 2018 kernel/experimental: Remove subsystem option from COMMIT-QUEUE.ini This CL targets third_party/kernel/experimental/COMMIT-QUEUE.ini BUG=chromium:683362 TEST=tryjob Change-Id: I43f77c149f9ce60bd91899aea7f938677957613d Reviewed-on: https://chromium-review.googlesource.com/1124930 Tested-by: Dhanya Ganesh <dhanyaganesh@google.com> Trybot-Ready: Dhanya Ganesh <dhanyaganesh@google.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> Commit-Queue: Dhanya Ganesh <dhanyaganesh@google.com> [modify] https://crrev.com/db0ecad3897c96c13bcaaf6f37dadb6bf0e3ec7f/COMMIT-QUEUE.ini
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/865a06d2aa4d45c6a3c9d78eadf13260a8d7828c commit 865a06d2aa4d45c6a3c9d78eadf13260a8d7828c Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Fri Jul 06 17:09:09 2018 kernelv3.8: Remove subsystem option from COMMIT-QUEUE.ini This CL targets third_party/kernel/v3.8/COMMIT-QUEUE.ini BUG=chromium:683362 TEST=tryjob Change-Id: I6eab0db62d6f283970f18de9973e7c77cc976a01 Reviewed-on: https://chromium-review.googlesource.com/1124927 Commit-Ready: Dhanya Ganesh <dhanyaganesh@google.com> Tested-by: Dhanya Ganesh <dhanyaganesh@google.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/865a06d2aa4d45c6a3c9d78eadf13260a8d7828c/COMMIT-QUEUE.ini
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b2f2c0a1814b612e1b7a5c48a65ebd96697b5b0a commit b2f2c0a1814b612e1b7a5c48a65ebd96697b5b0a Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Fri Jul 06 17:09:03 2018 kernelv4.14: Remove subsystem option from COMMIT-QUEUE.ini This CL targets third_party/kernel/v4.14/COMMIT-QUEUE.ini BUG=chromium:683362 TEST=tryjob Change-Id: Icdb8dce3a58e8e2d12fe7e6ad2fccff6214c337c Reviewed-on: https://chromium-review.googlesource.com/1124929 Commit-Ready: Dhanya Ganesh <dhanyaganesh@google.com> Tested-by: Dhanya Ganesh <dhanyaganesh@google.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/b2f2c0a1814b612e1b7a5c48a65ebd96697b5b0a/COMMIT-QUEUE.ini
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/084c4f8c16400cb79853c6c7c0811617cae8295d commit 084c4f8c16400cb79853c6c7c0811617cae8295d Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Fri Jul 06 17:09:01 2018 Autotest: Remove subsystem option from COMMIT-QUEUE.ini This CL targets third_party/autotest/files/COMMIT-QUEUE.ini BUG=chromium:683362 TEST=tryjob Change-Id: I2de4c550420ffacbd27a9391fcb8de6bbe88c083 Reviewed-on: https://chromium-review.googlesource.com/1124877 Commit-Ready: Dhanya Ganesh <dhanyaganesh@google.com> Tested-by: Dhanya Ganesh <dhanyaganesh@google.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/084c4f8c16400cb79853c6c7c0811617cae8295d/COMMIT-QUEUE.ini
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/6ec6a36dd1be9c4354195c9374a395ea50b2a8bf commit 6ec6a36dd1be9c4354195c9374a395ea50b2a8bf Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Fri Jul 06 17:09:07 2018 kernelv3.14: Remove subsystem option from COMMIT-QUEUE.ini This CL targets third_party/kernel/v3.14/COMMIT-QUEUE.ini BUG=chromium:683362 TEST=tryjob Change-Id: I7459537293f8cdf7258bc671dd95ceae72b34c2b Reviewed-on: https://chromium-review.googlesource.com/1124928 Commit-Ready: Dhanya Ganesh <dhanyaganesh@google.com> Tested-by: Dhanya Ganesh <dhanyaganesh@google.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/6ec6a36dd1be9c4354195c9374a395ea50b2a8bf/COMMIT-QUEUE.ini
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/403d43a34864389d2bd53b5bf4ecb5b24109399a commit 403d43a34864389d2bd53b5bf4ecb5b24109399a Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Fri Jul 06 17:09:06 2018 kernelv3.10: Remove subsystem option from COMMIT-QUEUE.ini This CL targets third_party/kernel/v3.10/COMMIT-QUEUE.ini BUG=chromium:683362 TEST=tryjob Change-Id: If853f4d678558e1ac00bae8be2f27d85d3811eee Reviewed-on: https://chromium-review.googlesource.com/1124923 Commit-Ready: Dhanya Ganesh <dhanyaganesh@google.com> Tested-by: Dhanya Ganesh <dhanyaganesh@google.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/403d43a34864389d2bd53b5bf4ecb5b24109399a/COMMIT-QUEUE.ini
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/18028b6002b19c98f47b2ee28ad3676633112d51 commit 18028b6002b19c98f47b2ee28ad3676633112d51 Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Fri Jul 06 17:09:12 2018 kernelv4.4: Remove subsystem option from COMMIT-QUEUE.ini This CL targets third_party/kernel/v4.4/COMMIT-QUEUE.ini BUG=chromium:683362 TEST=tryjob Change-Id: I1dab7ef6f02812985feeb00e55c3605f956dd4c1 Reviewed-on: https://chromium-review.googlesource.com/1124920 Commit-Ready: Dhanya Ganesh <dhanyaganesh@google.com> Tested-by: Dhanya Ganesh <dhanyaganesh@google.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/18028b6002b19c98f47b2ee28ad3676633112d51/COMMIT-QUEUE.ini
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/20d39e21e5555ff99dcba3f1ec6899b415ee6837 commit 20d39e21e5555ff99dcba3f1ec6899b415ee6837 Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Fri Jul 06 17:09:11 2018 kernelv3.18: Remove subsystem option from COMMIT-QUEUE.ini This CL targets third_party/kernel/v3.18/COMMIT-QUEUE.ini BUG=chromium:683362 TEST=tryjob Change-Id: I5bf66227229bd402dd8b11a8e0bcd6075f7e0de5 Reviewed-on: https://chromium-review.googlesource.com/1124926 Commit-Ready: Dhanya Ganesh <dhanyaganesh@google.com> Tested-by: Dhanya Ganesh <dhanyaganesh@google.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/20d39e21e5555ff99dcba3f1ec6899b415ee6837/COMMIT-QUEUE.ini
,
Jul 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/80b94824e45119b878d4493c98237c8bd6c493c7 commit 80b94824e45119b878d4493c98237c8bd6c493c7 Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Sat Jul 07 01:48:38 2018 shill: Remove COMMIT-QUEUE.ini BUG=chromium:683362 TEST=tryjob Change-Id: I4f7576ddb7dd60e7c96b38bc91604671d781fc50 Reviewed-on: https://chromium-review.googlesource.com/1124932 Commit-Ready: Dhanya Ganesh <dhanyaganesh@google.com> Tested-by: Dhanya Ganesh <dhanyaganesh@google.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> [delete] https://crrev.com/d68020ca4cc3fc87838eb633b3123b412e97ce27/chromeos-base/shill/COMMIT-QUEUE.ini
,
Jul 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/7cba7fb41f45df7dad0a317f2de679364728adfd commit 7cba7fb41f45df7dad0a317f2de679364728adfd Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Sun Jul 15 01:11:46 2018 CQ: Remove subsytem-based logic Remove all extra logic for subsystem based pass filtering in COMMIT-QUEUE.ini files and commit messages. The option was not being used anywhere in the codebase. BUG=chromium:683362 TEST=tryjob Change-Id: Ia5d47f761eeb312d5b774ca118043bd15a2b8d59 Reviewed-on: https://chromium-review.googlesource.com/1125357 Commit-Ready: Dhanya Ganesh <dhanyaganesh@google.com> Tested-by: Dhanya Ganesh <dhanyaganesh@google.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/7cba7fb41f45df7dad0a317f2de679364728adfd/cbuildbot/validation_pool.py [modify] https://crrev.com/7cba7fb41f45df7dad0a317f2de679364728adfd/cbuildbot/relevant_changes.py [modify] https://crrev.com/7cba7fb41f45df7dad0a317f2de679364728adfd/cbuildbot/stages/report_stages_unittest.py [modify] https://crrev.com/7cba7fb41f45df7dad0a317f2de679364728adfd/cbuildbot/relevant_changes_unittest.py [modify] https://crrev.com/7cba7fb41f45df7dad0a317f2de679364728adfd/cbuildbot/validation_pool_unittest.py [modify] https://crrev.com/7cba7fb41f45df7dad0a317f2de679364728adfd/lib/triage_lib_unittest.py [modify] https://crrev.com/7cba7fb41f45df7dad0a317f2de679364728adfd/cbuildbot/stages/handle_changes_stages.py [modify] https://crrev.com/7cba7fb41f45df7dad0a317f2de679364728adfd/lib/constants.py [modify] https://crrev.com/7cba7fb41f45df7dad0a317f2de679364728adfd/cbuildbot/stages/handle_changes_stages_unittest.py [modify] https://crrev.com/7cba7fb41f45df7dad0a317f2de679364728adfd/lib/triage_lib.py [modify] https://crrev.com/7cba7fb41f45df7dad0a317f2de679364728adfd/cbuildbot/stages/report_stages.py
,
Jul 16
,
Jul 16
Let's keep working on getting all of the subsystem code out: http://cs/search/?q=subsystem+f:chromite&m=25&sq=package:%5Echromeos&type=cs
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/840d30dcd550d7cf5b08a21fb5c9383f1d588da5 commit 840d30dcd550d7cf5b08a21fb5c9383f1d588da5 Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Wed Aug 15 19:55:00 2018 CQ: Remove subsytem-based logic Remove remaining logic for subsystem based pass filtering. The option was not being used anywhere in the codebase. BUG=chromium:683362 TEST=tryjob Change-Id: I33ab375075990b019848edf069fa6d44cb594e5f Reviewed-on: https://chromium-review.googlesource.com/1152104 Commit-Ready: Dhanya Ganesh <dhanyaganesh@chromium.org> Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/840d30dcd550d7cf5b08a21fb5c9383f1d588da5/lib/cq_config.py [modify] https://crrev.com/840d30dcd550d7cf5b08a21fb5c9383f1d588da5/lib/cq_config_unittest.py [modify] https://crrev.com/840d30dcd550d7cf5b08a21fb5c9383f1d588da5/cbuildbot/stages/test_stages.py [modify] https://crrev.com/840d30dcd550d7cf5b08a21fb5c9383f1d588da5/cbuildbot/commands.py [modify] https://crrev.com/840d30dcd550d7cf5b08a21fb5c9383f1d588da5/cbuildbot/commands_unittest.py
,
Sep 10
Is this fixed/done now?
,
Sep 10
There's no subsystem code left in Chromite: https://cs.corp.google.com/search/?q=subsystem+file:chromite/&m=100&sq=package:%5Echromeos&type=cs The next step would be to remove the option from autotest. I need a bit of hand-holding for that.
,
Sep 10
We can hand that off to the Test team since that's their domain. |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by shuqianz@chromium.org
, Jun 20 2017