Add a dependency on chromeos-config{,-tools} to chromeos-login, etc. |
|||
Issue descriptionAny ebuild that uses unibuild needs to depend on these. unibuild? ( chromeos-base/chromeos-config chromeos-base/chromeos-config-tools )
,
Jan 20 2017
chromeos-login here: https://chromium-review.googlesource.com/#/c/431130/ This is currently the only package that needs the run-time config. I will have to remember to add this dependency on all other packages that need it when I update their ebuilds.
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2101374d6ef5d62429560bea0bfaa70161361e5e commit 2101374d6ef5d62429560bea0bfaa70161361e5e Author: Simon Glass <sjg@chromium.org> Date: Fri Jan 20 21:39:46 2017 Require chromeos-config in chromeos-login When unified builds is active some packages need the Chrome OS master configuration. Rather than adding it as an overall Chrome OS dependency, we have decided to add it to each ebuild that needs it. Add a dependency for chromeos-login. BUG= chromium:683360 TEST=USE=unibuild equery-reef g chromeos-login See that chromeos-config shows up as a dependency Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: Ib28db8828e967f57e05297577ce9725c2e37196d Reviewed-on: https://chromium-review.googlesource.com/431130 Commit-Ready: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/2101374d6ef5d62429560bea0bfaa70161361e5e/chromeos-base/chromeos-login/chromeos-login-9999.ebuild
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6af95e0b9a6ca52b0620dfe567b5c3115c3faea5 commit 6af95e0b9a6ca52b0620dfe567b5c3115c3faea5 Author: Mike Frysinger <vapier@chromium.org> Date: Fri Jan 20 22:52:39 2017 chromeos-config-tools: drop unneeded CROS_WORKON_DESTDIR setting This isn't needed and causes problems when building out of tree. BUG= chromium:683360 TEST=precq passes Change-Id: I691c58c59ef19b8a8e19e378bca775ab4ccc98fb Reviewed-on: https://chromium-review.googlesource.com/431210 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/6af95e0b9a6ca52b0620dfe567b5c3115c3faea5/chromeos-base/chromeos-config-tools/chromeos-config-tools-9999.ebuild
,
Jan 26 2017
I think that's the only change needed so far. |
|||
►
Sign in to add a comment |
|||
Comment 1 by sjg@chromium.org
, Jan 20 2017Status: Assigned (was: Available)