New issue
Advanced search Search tips

Issue 683356 link

Starred by 2 users
Status: Assigned
Owner:
tapted@chromium.org
Cc:
kylixrd@chromium.org
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug
Launch-M-Target: 64-Beta

Blocking:
issue 630357



Sign in to add a comment

Harmony - update confirm form resubmission dialog (and use it on Mac)

Project Member Reported by tapted@chromium.org, Jan 20 2017 
Chrome Version       : 55.0.2883.95

Not sure if there is a mock. Similar to http-auth ( Issue 602392 )

Not hooked up on views yet (old-style Cocoa dialog attached).
Screen Shot 2017-01-20 at 13.08.16.png
236 KB View Download

Comment 1 by pkasting@chromium.org, Jan 26 2017

Labels: OS-Chrome OS-Linux OS-Windows
Summary: Harmony - update confirm form resubmission dialog (was: Harmony: Confirm form resubmission)
No mock, but should look very similar to the reload confirmation dialog ( bug 652017 ).

Doesn't seem Mac-specific, unless you wanted to use this bug just to track "MacViews should use the Views version of this" and track updating the dialog to Harmony style separately (in which case please feel free to clarify/update/file new bugs as needed).

Comment 2 by abdulsyed@google.com, Sep 5 2017

Labels: Launch-M-Target-64-Beta

Comment 3 by abdulsyed@google.com, Sep 5 2017

NextAction: 2017-11-10

Comment 4 by monor...@bugs.chromium.org, Nov 10 2017 

The NextAction date has arrived: 2017-11-10

Comment 5 by bsep@chromium.org, Dec 14 2017

Owner: kylixrd@chromium.org
Status: Assigned (was: Available)
Load balancing

Comment 6 by kylixrd@chromium.org, Dec 15 2017 

Here is how this dialog currently looks on Windows. This should be about complete.
ConfirmFormResubmission.png
7.2 KB View Download

Comment 7 by tapted@chromium.org, Jan 3 2018

Summary: Harmony - update confirm form resubmission dialog (and use it on Mac) (was: Harmony - update confirm form resubmission dialog)
Note this still needs some plumbing to show up on Mac. Feel free to bump it to myself or Elly for the mac-specific stuff.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a20daa8782ec682a37c9646a91a0675bee691eca

commit a20daa8782ec682a37c9646a91a0675bee691eca
Author: Allen Bauer <kylixrd@chromium.org>
Date: Mon Jan 08 20:55:44 2018

Added browser test for interactively invoking the form repost warning dialog.

Bug: 683356
Change-Id: I290f7329f202285c0ed413472ca0e82d4c55754f
Reviewed-on: https://chromium-review.googlesource.com/829975
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527750}
[modify] https://crrev.com/a20daa8782ec682a37c9646a91a0675bee691eca/chrome/browser/repost_form_warning_browsertest.cc

Comment 9 by kylixrd@chromium.org, Jan 9 2018

Owner: tapted@chromium.org
Moved to tapted@ to cover the mac-specific work.
►

Sign in to add a comment