Mac and iOS builds with ToT clang broken by libc++ const call operator diagnostic change |
||||||||
Issue descriptionExample build: https://build.chromium.org/p/chromium.fyi/builders/ClangToTiOS/builds/10010 Error message: FAILED: clang_x64/obj/third_party/protobuf/protoc_lib/java_file.o ... In file included from ../../third_party/protobuf/src/google/protobuf/compiler/java/java_file.cc:41: In file included from /b/build/slave/ClangToTiOS/build/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/set:389: /b/build/slave/ClangToTiOS/build/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__tree:1815:22: error: the specified comparator type does not provide a const call operator [-Werror,-Wuser-defined-warnings] __trigger_diagnostics()), ""); ^ /b/build/slave/ClangToTiOS/build/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/set:400:28: note: in instantiation of member function 'std::__1::__tree<const google::protobuf::FieldDescriptor *, google::protobuf::compiler::java::(anonymous namespace)::FieldDescriptorCompare, std::__1::allocator<const google::protobuf::FieldDescriptor *> >::~__tree' requested here class _LIBCPP_TEMPLATE_VIS set ^ /b/build/slave/ClangToTiOS/build/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__tree:966:7: note: from 'diagnose_if' attribute on '__trigger_diagnostics': _LIBCPP_DIAGNOSE_WARNING(!__invokable<_Compare const&, _Tp const&, _Tp const&>::value, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /b/build/slave/ClangToTiOS/build/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__config:1036:20: note: expanded from macro '_LIBCPP_DIAGNOSE_WARNING' __attribute__((diagnose_if(__VA_ARGS__, "warning"))) ^ ~~~~~~~~~~~ 1 error generated. This was introduced a week ago in r291969.
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59c02c3aa8f983c2adecb654bd71e2ada5fb4d8e commit 59c02c3aa8f983c2adecb654bd71e2ada5fb4d8e Author: thakis <thakis@chromium.org> Date: Mon Jan 23 17:45:48 2017 clang tot: Disable -Wuser-defined-warnings BUG= 683349 TBR=hans Review-Url: https://codereview.chromium.org/2649163002 Cr-Commit-Position: refs/heads/master@{#445401} [modify] https://crrev.com/59c02c3aa8f983c2adecb654bd71e2ada5fb4d8e/build/config/compiler/BUILD.gn
,
Jan 23 2017
,
Jan 26 2017
Unassigning from myself: I don't have an access to a MacOS machine anyway.
,
Feb 12 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 15 2018
This was over a year ago, and I haven't run into any issues like this in a while. Justin, could you verify that this no longer reproduces?
,
Feb 16 2018
thakis@ is there anything else to do here after disabling user-defined-warnings?
,
Oct 17
I'm interested in this.
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6f218934448da30cabb3f3150c611554987f603a commit 6f218934448da30cabb3f3150c611554987f603a Author: Takuto Ikuta <tikuta@chromium.org> Date: Wed Oct 17 11:40:50 2018 Specify const for operator() in LiveRangeOrdering This is a preparation CL to remove -Wno-user-defined-warnings warning suppression. Bug: chromium:683349 Change-Id: If883c24ebac66292329abaf01c5d328bfd51c5c9 Reviewed-on: https://chromium-review.googlesource.com/c/1286391 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#56727} [modify] https://crrev.com/6f218934448da30cabb3f3150c611554987f603a/src/compiler/register-allocator.h
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9764f3e0e9cd3126281c887ef3f06c9c427fb69a commit 9764f3e0e9cd3126281c887ef3f06c9c427fb69a Author: Takuto Ikuta <tikuta@chromium.org> Date: Fri Oct 19 04:45:17 2018 Remove -Wno-user-defined-warnings flag The flag suppressed user defined warning from libc++ https://github.com/llvm-project/llvm-project-20170507/blob/a2e822e3ac432da65d730dca1f2cbeee49f6e235/libcxx/include/__tree#L1848 I think this will be useful to prevent forgotten const. Bug: 683349 Change-Id: I24199ae9bf065ee6560b6caa397cd5fd8c042e83 Reviewed-on: https://chromium-review.googlesource.com/c/1286103 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601055} [modify] https://crrev.com/9764f3e0e9cd3126281c887ef3f06c9c427fb69a/ash/accelerators/accelerator_table_unittest.cc [modify] https://crrev.com/9764f3e0e9cd3126281c887ef3f06c9c427fb69a/build/config/compiler/BUILD.gn [modify] https://crrev.com/9764f3e0e9cd3126281c887ef3f06c9c427fb69a/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc [modify] https://crrev.com/9764f3e0e9cd3126281c887ef3f06c9c427fb69a/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h [modify] https://crrev.com/9764f3e0e9cd3126281c887ef3f06c9c427fb69a/third_party/sfntly/BUILD.gn [modify] https://crrev.com/9764f3e0e9cd3126281c887ef3f06c9c427fb69a/ui/gfx/image/image_generic.cc
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c61076353affd2a8f7df40388e8568cf17299d3 commit 3c61076353affd2a8f7df40388e8568cf17299d3 Author: Takuto Ikuta <tikuta@chromium.org> Date: Wed Nov 07 01:03:00 2018 Roll src/third_party/sfntly/src/ 280414815..b55ff303e (3 commits) https://chromium.googlesource.com/external/github.com/googlei18n/sfntly.git/+log/2804148152d2..b55ff303ea2f $ git log 280414815..b55ff303e --date=short --no-merges --format='%ad %ae %s' 2018-10-17 tikuta Specify const for operator() 2018-09-27 nyshadhr Add tests for EOT's 255SHORT encoding 2018-09-26 nyshadhr Fix encoding for EOT's 255SHORT Created with: roll-dep src/third_party/sfntly/src Also removed unnecessary flag. TBR: thestig@chromium.org Bug: 683349 Change-Id: I0a00b965126ad4ff10855ae24835706c397dc8af Reviewed-on: https://chromium-review.googlesource.com/c/1320989 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#605902} [modify] https://crrev.com/3c61076353affd2a8f7df40388e8568cf17299d3/DEPS [modify] https://crrev.com/3c61076353affd2a8f7df40388e8568cf17299d3/third_party/sfntly/BUILD.gn [modify] https://crrev.com/3c61076353affd2a8f7df40388e8568cf17299d3/third_party/sfntly/README.chromium
,
Nov 7
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by thakis@chromium.org
, Jan 23 2017