https://codereview.chromium.org/2643123004/ will break paint/invalidation/paged-with-overflowing-block-rl.html , because it's fixing a way more serious bug.
mstensho@, are you looking into this? We're trying to avoid leaving expectations sitting in TestExpectations for long periods because it removes test coverage. Standard practice would be to rebaseline to the incorrect result and leave the bug open.
@schenney, No, not looking into it at the moment, so rebaselining sounds like a plan? Shall I do it?
Thanks. I will do it. I'm working through rebaselining everything paint and invalidation related, and I'm in the best place to avoid merge conflicts.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/959aa7f6f37c53cd282c7e4a9495a648f43847e2 commit 959aa7f6f37c53cd282c7e4a9495a648f43847e2 Author: schenney <schenney@chromium.org> Date: Wed Mar 22 19:40:10 2017 Rebaseline paint/invalidation/paged-with-overflowing-block-rl.html The result regressed when a more serious issue was fixed. It's not likely to get fixed real soon, so rebaseline the result to get coverage of other changes but leave th ebug open so we know we're failing. TBR=mstensho@opera.com BUG= 683339 Review-Url: https://codereview.chromium.org/2762943005 Cr-Commit-Position: refs/heads/master@{#458844} [modify] https://crrev.com/959aa7f6f37c53cd282c7e4a9495a648f43847e2/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/959aa7f6f37c53cd282c7e4a9495a648f43847e2/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/paged-with-overflowing-block-rl-expected.png [add] https://crrev.com/959aa7f6f37c53cd282c7e4a9495a648f43847e2/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/paged-with-overflowing-block-rl-expected.png [modify] https://crrev.com/959aa7f6f37c53cd282c7e4a9495a648f43847e2/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/paged-with-overflowing-block-rl-expected.png [add] https://crrev.com/959aa7f6f37c53cd282c7e4a9495a648f43847e2/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/paged-with-overflowing-block-rl-expected.png [modify] https://crrev.com/959aa7f6f37c53cd282c7e4a9495a648f43847e2/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/paged-with-overflowing-block-rl-expected.png [add] https://crrev.com/959aa7f6f37c53cd282c7e4a9495a648f43847e2/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/paged-with-overflowing-block-rl-expected.png [modify] https://crrev.com/959aa7f6f37c53cd282c7e4a9495a648f43847e2/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/paged-with-overflowing-block-rl-expected.png [add] https://crrev.com/959aa7f6f37c53cd282c7e4a9495a648f43847e2/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/paged-with-overflowing-block-rl-expected.png
Chris, apparently you're fixing this with https://chromium-review.googlesource.com/c/chromium/src/+/646700 :)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3a3481c4b1b08775b477144d1d2873a2a3d9900 commit c3a3481c4b1b08775b477144d1d2873a2a3d9900 Author: Chris Harrelson <chrishtr@chromium.org> Date: Sat Sep 09 06:46:57 2017 Implement fragmentation in the pre-paint tree walk. Compute fragments, fragment clips, pagination offset, and paint offset that includes fragmentation. Store fragment clips in the clip paint property tree. Fragment clips sit above other clips, effects and transforms that belong to a LayoutObject. They also contribute to LocalBorderBoxProperties. However, fragment clips have no children in the clip tree, and hence only apply to that specific LayoutObject. This is because every LayoutObject (which has a PaintLayer) fragments itself, and does not inherit fragment clips from any ancestor. Paint offsets for fragments are currently stored separately from paint offsets for LayoutObjects. The latter are unchanged in this patch, and hence do not take fragmentation into account (see #1 below). Still to be done in future patches: 1. Remove the slow path in PaintInvalidator for fragmentation, and remove the paint offset field from LayoutObject. 2. Change other callsites to FirstFragment() that ignore other fragments to be fragmentation-aware. Bug: 648274 , 683339 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I32b093091172878c21163b66923cac88c5176597 Reviewed-on: https://chromium-review.googlesource.com/646700 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#500792} [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/LayoutTests/fast/multicol/transform-inside-opacity-expected.png [add] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/LayoutTests/fast/multicol/transform-inside-opacity-expected.txt [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/LayoutTests/fast/multicol/transform-inside-opacity.html [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/paged-with-overflowing-block-rl-expected.png [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/paged-with-overflowing-block-rl-expected.png [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/paged-with-overflowing-block-rl-expected.png [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/paged-with-overflowing-block-rl-expected.png [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/exported/WebViewTest.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/FragmentData.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/FragmentData.h [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/PaintLayer.h [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/PaintLayerClipper.h [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/README.md [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/paint/RarePaintData.h [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/scheduler/FrameThrottlingTest.cpp [modify] https://crrev.com/c3a3481c4b1b08775b477144d1d2873a2a3d9900/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
Comment 1 by msten...@opera.com
, Mar 20 2017