It2Me host crashes when 2 clients try to connect at the same time |
||||||
Issue descriptionWhat steps will reproduce the problem? (1) Share It2Me host (2) Open two client CRD windows, (3) Click "Access" in both windows. (4) Copy access code to both clients (5) Click "Connect". What is the expected result? One of the clients connects, another one doesn't What happens instead? Host crashes.
,
Jan 24 2017
,
Mar 1 2017
,
Mar 2 2017
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f38c5d70b59fe17e1d3479081dd3f6bc1bfc1cb5 commit f38c5d70b59fe17e1d3479081dd3f6bc1bfc1cb5 Author: joedow <joedow@chromium.org> Date: Mon Mar 20 15:55:46 2017 Disconnect all users if too many connection requests are received for It2Me This change adds logic to disconnect the current session if multiple remote users attempt to use the same Access Code with It2Me. It adds a new rejection state and updates the It2MeHost unit tests. The previous behavior was to crash which was not the right thing to do. This CL also moves the point of validation from the 'incoming' state to the 'accepted' state. BUG= 683317 Review-Url: https://codereview.chromium.org/2724223003 Cr-Commit-Position: refs/heads/master@{#458075} [modify] https://crrev.com/f38c5d70b59fe17e1d3479081dd3f6bc1bfc1cb5/remoting/host/it2me/it2me_host.cc [modify] https://crrev.com/f38c5d70b59fe17e1d3479081dd3f6bc1bfc1cb5/remoting/host/it2me/it2me_host.h [modify] https://crrev.com/f38c5d70b59fe17e1d3479081dd3f6bc1bfc1cb5/remoting/host/it2me/it2me_host_unittest.cc [modify] https://crrev.com/f38c5d70b59fe17e1d3479081dd3f6bc1bfc1cb5/remoting/protocol/authenticator.h [modify] https://crrev.com/f38c5d70b59fe17e1d3479081dd3f6bc1bfc1cb5/remoting/protocol/jingle_session.cc [modify] https://crrev.com/f38c5d70b59fe17e1d3479081dd3f6bc1bfc1cb5/remoting/protocol/validating_authenticator.cc [modify] https://crrev.com/f38c5d70b59fe17e1d3479081dd3f6bc1bfc1cb5/remoting/protocol/validating_authenticator.h [modify] https://crrev.com/f38c5d70b59fe17e1d3479081dd3f6bc1bfc1cb5/remoting/protocol/validating_authenticator_unittest.cc
,
Mar 20 2017
,
Apr 6 2017
Verified fixed in 59.0.3064.0. Host does not crash. One of the two clients connects, the other continues to attempt connection then times out. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jamiewa...@chromium.org
, Jan 24 2017Status: Assigned (was: Untriaged)