New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 683312 link

Starred by 1 user
Status: Fixed
Owner:
robertphillips@chromium.org
Closed: Jan 2017
Cc:
█ jcgregorio@chromium.org
hcm@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rebaseline layout test image for Skia DEPS roll

Project Member Reported by robertphillips@chromium.org, Jan 20 2017 
The Skia CL: 
https://skia-review.googlesource.com/c/7265/ (Continue making Ganesh use absolute texture coordinates - take 2)

altered the following layout test:

virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations.html [ Failure ]

The image differences are imperceptible and just need to be rebaselined (once Skia resumes rolling into Chromium)

Comment 1 by hcm@google.com, Jan 21 2017 

We're ready to roll into Chromium now but I have not flipped the switch- is there a change to flag or ignore the test?

Comment 2 by jcgrego...@google.com, Jan 21 2017 

I just hit commit on this:

  https://codereview.chromium.org/2647973002/

Once that lands we should be OK to start the roll again.

Comment 3 by hcm@google.com, Jan 21 2017 

Thanks! I was on cc but somehow (2 kids with flu) missed that one!
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e03a131eaf48ffbd708263f5e86be5b4f0c486f

commit 0e03a131eaf48ffbd708263f5e86be5b4f0c486f
Author: robertphillips <robertphillips@google.com>
Date: Sat Jan 21 05:13:26 2017

Add layout test suppression for upcoming Skia DEPS roll

Not to be landed until Skia is about to start rolling again

BUG= 683312 

Review-Url: https://codereview.chromium.org/2647973002
Cr-Commit-Position: refs/heads/master@{#445272}

[modify] https://crrev.com/0e03a131eaf48ffbd708263f5e86be5b4f0c486f/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by jcgrego...@google.com, Jan 21 2017 

The CL has landed, now switching on the roll.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f34f92725f250f7028e43df9a40a3813cc82d99a

commit f34f92725f250f7028e43df9a40a3813cc82d99a
Author: robertphillips <robertphillips@google.com>
Date: Mon Jan 23 18:35:58 2017

Remove layout test suppression added for Skia DEPS roll

BUG= 683312 

Review-Url: https://codereview.chromium.org/2651683002
Cr-Commit-Position: refs/heads/master@{#445416}

[modify] https://crrev.com/f34f92725f250f7028e43df9a40a3813cc82d99a/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by robertphillips@chromium.org, Jan 26 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment