MD Settings: About Chrome OS page 'Restart' button is not shown properly after download of updates |
|||||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? 1. Device on 9199.0.0 2. Trigger AU to 9202.0.0 3. Wait for the download to finish What is the expected result? Only 'Restart' button should be seen What happens instead? 'Restart' and 'Check for updates' buttons are seen. Attached screenshot.
,
Jan 24 2017
,
Jan 24 2017
,
Jan 24 2017
,
Jan 25 2017
,
Jan 25 2017
sdantuluri: Can you clarify step 2 in the repro? How did you trigger the updates? Currently there is some logic that always shows the "Check for updates" button unless the user clicks on it once. Just visiting the about page does NOT trigger checking for updates, so in theory this logic should be sufficient, but apparently is not.
,
Jan 25 2017
dppad@ Step 2: I used 'autest' command from crosh terminal to trigger AU.
,
Jan 25 2017
Ok. I guess by triggering update by the command line, the assumption that "always show the check for updates button if user has not explicitly checked for updates" is broken. Will have to take a closer look at the old About page, or just come up with more robust logic.
,
Jan 26 2017
I am reducing P1->P2 since this only happens if updating is triggered without clicking the "Check for updates" button (AFAIK only possible from the command crosh command line, or from DevTools).
,
Jan 26 2017
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/154d75a41792c1314f36b86b3f2b1763e1c025a3 commit 154d75a41792c1314f36b86b3f2b1763e1c025a3 Author: dpapad <dpapad@chromium.org> Date: Fri Jan 27 00:43:15 2017 MD Settings: Fix case where "Check for updates" is accidentally shown. BUG= 683305 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2655193002 Cr-Commit-Position: refs/heads/master@{#446504} [modify] https://crrev.com/154d75a41792c1314f36b86b3f2b1763e1c025a3/chrome/browser/resources/settings/about_page/about_page.js [modify] https://crrev.com/154d75a41792c1314f36b86b3f2b1763e1c025a3/chrome/test/data/webui/settings/about_page_tests.js
,
Jan 31 2017
,
Feb 10 2017
Verified on TOT 9270.0.0, 58.0.3007.0 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by abodenha@chromium.org
, Jan 24 2017