New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683305 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 684849



Sign in to add a comment

MD Settings: About Chrome OS page 'Restart' button is not shown properly after download of updates

Project Member Reported by sdantul...@chromium.org, Jan 20 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
1. Device on 9199.0.0
2. Trigger AU to 9202.0.0
3. Wait for the download to finish

What is the expected result?
Only 'Restart' button should be seen

What happens instead?
'Restart' and 'Check for updates' buttons are seen.

Attached screenshot.
 
Screenshot 2017-01-20 at 11.03.32.png
71.6 KB View Download
Owner: dbeam@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by dbeam@chromium.org, Jan 24 2017

Cc: scottchen@chromium.org dbeam@chromium.org
Labels: -M-57
Owner: dpa...@chromium.org
Blocking: 684849

Comment 5 by tbuckley@google.com, Jan 25 2017

Labels: Hotlist-MD-Settings-About

Comment 6 by dpa...@chromium.org, Jan 25 2017

sdantuluri: Can you clarify step 2 in the repro?

How did you trigger the updates? Currently there is some logic that always shows the "Check for updates" button unless the user clicks on it once. Just visiting the about page does NOT trigger checking for updates, so in theory this logic should be sufficient, but apparently is not.
negative_margin.mp4
429 KB View Download
dppad@ Step 2: I used 'autest' command from crosh terminal to trigger AU.

Comment 8 by dpa...@chromium.org, Jan 25 2017

Ok. I guess by triggering update by the command line, the assumption that "always show the check for updates button if user has not explicitly checked for updates" is broken. Will have to take a closer look at the old About page, or just come up with more robust logic. 

Comment 9 by dpa...@chromium.org, Jan 26 2017

Labels: -Pri-1 Pri-2
I am reducing P1->P2 since this only happens if updating is triggered without clicking the "Check for updates" button (AFAIK only possible from the command crosh command line, or from DevTools).
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/154d75a41792c1314f36b86b3f2b1763e1c025a3

commit 154d75a41792c1314f36b86b3f2b1763e1c025a3
Author: dpapad <dpapad@chromium.org>
Date: Fri Jan 27 00:43:15 2017

MD Settings: Fix case where "Check for updates" is accidentally shown.

BUG= 683305 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2655193002
Cr-Commit-Position: refs/heads/master@{#446504}

[modify] https://crrev.com/154d75a41792c1314f36b86b3f2b1763e1c025a3/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/154d75a41792c1314f36b86b3f2b1763e1c025a3/chrome/test/data/webui/settings/about_page_tests.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on TOT  9270.0.0, 58.0.3007.0

Sign in to add a comment