The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20d16215e1bd867da6a23887046f4d6894222c00

commit 20d16215e1bd867da6a23887046f4d6894222c00
Author: jialiul <jialiul@chromium.org>
Date: Fri Jan 27 20:51:40 2017

Since SafeBrowsingNavigationObserverManager cleans up navigation
events every two minutes, if downloading a file takes more than 2
minutes, we'll get nothing from the attribution logic.
Therefore, this CL moves the download attribution logic to
after download url checking (before download starts).

This CL also changes the way of how referrer chain is constructed.
Instead of putting referrer entries in a temporary vector, I put
them directly into a RepeatedPtrField<ReferrerChainEntry> to avoid
extra copying/moving operations. This should mitigate the out-of
-memory issue.

BUG= 683299 ,676675

Review-Url: https://codereview.chromium.org/2647323004
Cr-Commit-Position: refs/heads/master@{#446761}

[modify] https://crrev.com/20d16215e1bd867da6a23887046f4d6894222c00/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/20d16215e1bd867da6a23887046f4d6894222c00/chrome/browser/safe_browsing/download_protection_service.cc
[modify] https://crrev.com/20d16215e1bd867da6a23887046f4d6894222c00/chrome/browser/safe_browsing/download_protection_service.h
[modify] https://crrev.com/20d16215e1bd867da6a23887046f4d6894222c00/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[modify] https://crrev.com/20d16215e1bd867da6a23887046f4d6894222c00/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
[modify] https://crrev.com/20d16215e1bd867da6a23887046f4d6894222c00/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
[modify] https://crrev.com/20d16215e1bd867da6a23887046f4d6894222c00/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d14f396060bdb6639dba6664ee77fe2f2e3e423

commit 0d14f396060bdb6639dba6664ee77fe2f2e3e423
Author: Jialiu Lin <jialiul@chromium.org>
Date: Wed Feb 08 01:44:34 2017

Since SafeBrowsingNavigationObserverManager cleans up navigation events every two minutes, if downloading a file takes more than 2 minutes, we'll get nothing from the attribution logic. Therefore, this CL moves the download attribution logic to after download url checking (before download starts).

This CL also changes the way of how referrer chain is constructed.
Instead of putting referrer entries in a temporary vector, I put
them directly into a RepeatedPtrField<ReferrerChainEntry> to avoid
extra copying/moving operations. This should mitigate the out-of
-memory issue.

BUG= 683299 ,676675

Review-Url: https://codereview.chromium.org/2647323004
Cr-Commit-Position: refs/heads/master@{#446761}
(cherry picked from commit 20d16215e1bd867da6a23887046f4d6894222c00)

Review-Url: https://codereview.chromium.org/2681783003 .
Cr-Commit-Position: refs/branch-heads/2987@{#375}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/0d14f396060bdb6639dba6664ee77fe2f2e3e423/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/0d14f396060bdb6639dba6664ee77fe2f2e3e423/chrome/browser/safe_browsing/download_protection_service.cc
[modify] https://crrev.com/0d14f396060bdb6639dba6664ee77fe2f2e3e423/chrome/browser/safe_browsing/download_protection_service.h
[modify] https://crrev.com/0d14f396060bdb6639dba6664ee77fe2f2e3e423/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[modify] https://crrev.com/0d14f396060bdb6639dba6664ee77fe2f2e3e423/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
[modify] https://crrev.com/0d14f396060bdb6639dba6664ee77fe2f2e3e423/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
[modify] https://crrev.com/0d14f396060bdb6639dba6664ee77fe2f2e3e423/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h