Clean up LG Email workaround version check |
||||||
Issue descriptionThe workarounds for LG Email/IME interaction don't check targetSdkVersion properly and the APK version is too high. Clean up at https://codereview.chromium.org/2643943004
,
Jan 23 2017
,
Jan 23 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c274309d19ab755d13fc41d03be2c28aa21d71d commit 0c274309d19ab755d13fc41d03be2c28aa21d71d Author: Alexandre Elias <aelias@chromium.org> Date: Mon Jan 23 23:02:44 2017 Fix LG Email workaround criteria. 1) We were accidentally checking Build.VERSION.SDK_INT (version of the WebView package) when the intent was to check the targetSdkVersion of the app package itself. This would come to bite us and globally disable the workaround when we upgrade the WebView to O. 2) Decrease the APK version check to 67502100 which is the version of com.lge.email actually shipped on LG V20. The intent is for the workaround to be purely grandfathering existing nonupdatable APKs so there isn't a reason to leave headroom. 3) Take advantage of PackageUtils.getPackageVersion. BUG=651706, 683294 Review-Url: https://codereview.chromium.org/2643943004 Cr-Commit-Position: refs/heads/master@{#445509} (cherry picked from commit 9079de0121eb747464e490e29fd2444dde5f0847) Review-Url: https://codereview.chromium.org/2649083003 . Cr-Commit-Position: refs/branch-heads/2987@{#44} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/0c274309d19ab755d13fc41d03be2c28aa21d71d/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java [modify] https://crrev.com/0c274309d19ab755d13fc41d03be2c28aa21d71d/content/public/android/java/src/org/chromium/content/browser/input/LGEmailActionModeWorkaround.java
,
Jan 24 2017
,
Jan 31 2017
verified with LG G5 / MMB29M - 57.0.2987.19 and vs: LG V20 LG-H990DS / NRD90M - 57.0.2987.19
,
Feb 6 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jan 23 2017