New issue
Advanced search Search tips

Issue 683289 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 672888
Owner: ----
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Chrome should register keyboard with mus

Project Member Reported by sky@chromium.org, Jan 20 2017

Issue description

See 672888 for the details as to why.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1340ff2da37b5fcd669e08842cea9223b325a873

commit 1340ff2da37b5fcd669e08842cea9223b325a873
Author: sky <sky@chromium.org>
Date: Fri Jan 20 21:30:53 2017

mash: Makes mash and service:ui not establish outgoing connections

The ui service was connecting to chrome for the ime driver. As the ui
service is a singleton and chrome isn't, this triggered launching
another process of chrome, which we don't want. Turns out having ui
connect to chrome for the ime driver is unnecessary as chrome already
does this. So, removing the code.

Mash was connecting to the chrome for the keyboard service. This is
also problematic for similar reasons, so removing it too. Filed bug
to have chrome register keyboard with mash.

BUG= 664267 , 662157 , 664264 , 683192 , 683289 
TEST=none
R=moshayedi@chromium.org

Review-Url: https://codereview.chromium.org/2645683007
Cr-Commit-Position: refs/heads/master@{#445172}

[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/ash/mus/BUILD.gn
[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/ash/mus/keyboard_ui_mus.cc
[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/BUILD.gn
[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/ime_server_impl.cc
[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/ime_server_impl.h
[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/manifest.json

Comment 2 by msw@chromium.org, Jan 22 2017

Mergedinto: 672888
Status: Duplicate (was: Untriaged)
This is a duplicate of  Issue 672888 , the last blocker for  Issue 670798 .

Sign in to add a comment