Merge PrintControllerTestCase and JSPrintTestCase together |
||||
Issue descriptionThese 2 test cases verify print dialogs and do have unnecessary code duplication. Those can live in a single Test Case
,
May 12 2017
,
Apr 4 2018
+pkl to weigh in on this The tests in PrintControllerTestCase invoke print via the share menu on iOS10, but they invoke print programmatically on iOS11. We already have programmatic tests for printing in JSPrintTestCase, so do the PrintControllerTestCase tests serve any purpose on iOS11? If we remove testPrintNormalPage as redundant, what about testPrintPDF? Is printing PDFs materially different from printing an HTML page, such that we should test it separately and try to find a way to fix that test on iOS11? JSPrintTestCase does not test printing PDFs. I think there's value in continuing to run these tests on iOS10, because there they exercise the UI.
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8527f90398bfd1ad04cfdecfe06b1e10625ce81 commit b8527f90398bfd1ad04cfdecfe06b1e10625ce81 Author: Rohit Rao <rohitrao@chromium.org> Date: Mon Apr 09 20:54:25 2018 [ios] Disables PrintControllerTests on iOS11 when UIRefresh is enabled. These tests cannot invoke Print via the share menu on iOS11, so they are redundant with the tests in JSPrintTestCase. BUG= 825431 ,683280 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0e9965dfddf1e49d583a5304d7392cd59ac63bca Reviewed-on: https://chromium-review.googlesource.com/990533 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#549268} [modify] https://crrev.com/b8527f90398bfd1ad04cfdecfe06b1e10625ce81/ios/chrome/browser/ui/print/print_controller_egtest.mm
,
Sep 20
|
||||
►
Sign in to add a comment |
||||
Comment 1 by pkl@chromium.org
, Jan 23 2017Owner: baxley@chromium.org
Status: Assigned (was: Untriaged)