Disable precache on svelte |
||||||
Issue descriptionPrecache was enabled on svelte in http://crrev.com/c8e7c272, while the experiment was only on dev, in the interest in seeing the maximum percent of users that we could impact. The question came up at launch review of whether the background service will slow down svelte phones due to RAM/CPU requirements. We don't have any evidence to suggest either way, yet. In the interest of eliminating risk in advance of our 100% stable launch, we want to avoid launching on svelte devices.
,
Jan 20 2017
Merge approved for M56 branch 2924 and M57 (likely branch is 2987 but please wait for the branch announcement email to come out before merging there). As discussed please test on a Svelte device on Monday with an official build and let me know if anything goes awry, otherwise I'll assume we are all set. Thanks!
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de386febc8d9e576e2fbd4ed60545ec50b2e7872 commit de386febc8d9e576e2fbd4ed60545ec50b2e7872 Author: Devin Mullins <twifkak@google.com> Date: Fri Jan 20 21:19:21 2017 Disable precache on svelte. Precache was enabled for svelte in http://crrev.com/c8e7c272, when the experiment was only on dev, in the interest in seeing the maximum percent of users that we could impact. There is an unconfirmed possibility that the background service may slow down phones with low RAM/CPU. Until we verify that it does not, we would like to avoid launching on svelte devices, in order to eliminate any potential for harm. This change re-disables the service on svelte devices, by checking PrivacyPreferencesManager#shouldPrerender() instead of PrefServiceBridge#getNetworkPredictionEnabled(). BUG= 683259 Review-Url: https://codereview.chromium.org/2642733004 Cr-Commit-Position: refs/heads/master@{#445110} (cherry picked from commit 5fe1163de91a80f23c4a2b68ca1d1a5c53319986) Review-Url: https://codereview.chromium.org/2647943003 . Cr-Commit-Position: refs/branch-heads/2924@{#821} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/de386febc8d9e576e2fbd4ed60545ec50b2e7872/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java [modify] https://crrev.com/de386febc8d9e576e2fbd4ed60545ec50b2e7872/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java
,
Jan 21 2017
,
Jan 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd98737fa64262a5b13631518fde382ff8ad9d36 commit dd98737fa64262a5b13631518fde382ff8ad9d36 Author: Devin Mullins <twifkak@google.com> Date: Sat Jan 21 04:43:09 2017 Disable precache on svelte. Precache was enabled for svelte in http://crrev.com/c8e7c272, when the experiment was only on dev, in the interest in seeing the maximum percent of users that we could impact. There is an unconfirmed possibility that the background service may slow down phones with low RAM/CPU. Until we verify that it does not, we would like to avoid launching on svelte devices, in order to eliminate any potential for harm. This change re-disables the service on svelte devices, by checking PrivacyPreferencesManager#shouldPrerender() instead of PrefServiceBridge#getNetworkPredictionEnabled(). BUG= 683259 Review-Url: https://codereview.chromium.org/2642733004 Cr-Commit-Position: refs/heads/master@{#445110} (cherry picked from commit 5fe1163de91a80f23c4a2b68ca1d1a5c53319986) Review-Url: https://codereview.chromium.org/2643393003 . Cr-Commit-Position: refs/branch-heads/2987@{#10} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/dd98737fa64262a5b13631518fde382ff8ad9d36/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java [modify] https://crrev.com/dd98737fa64262a5b13631518fde382ff8ad9d36/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java
,
Feb 23 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jan 20 2017