New issue
Advanced search Search tips

Issue 683247 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: 2017-07-19
OS: Linux , Android
Pri: 1
Type: ----

Blocking:
issue 575762



Sign in to add a comment

smoothness.scrolling_tough_ad_cases failing on 9 builders

Project Member Reported by alexandermont@chromium.org, Jan 20 2017

Issue description

Owner: fmea...@chromium.org
Status: Started (was: Available)
Disabling for now.
Labels: OS-Android OS-Linux
Summary: smoothness.scrolling_tough_ad_cases failing on 9 builders (was: smoothness.scrolling_tough_ad_cases failing on 8 builders)
Also failing on Linux:
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Linux%20Perf/builds/286/steps/smoothness.scrolling_tough_ad_cases%20on%20%28102b%29%20GPU%20on%20Linux%20on%20Ubuntu-14.04
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a7ecf6db8f4f070152509d450417f08866ed3e

commit 64a7ecf6db8f4f070152509d450417f08866ed3e
Author: fmeawad <fmeawad@chromium.org>
Date: Wed Jan 25 16:17:19 2017

[PerfBenchmarks] Disabled smoothness.scrolling_tough_ad_cases on Android

BUG= 683247 
# CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2652833005
Cr-Commit-Position: refs/heads/master@{#446029}

[modify] https://crrev.com/64a7ecf6db8f4f070152509d450417f08866ed3e/tools/perf/benchmarks/smoothness.py

Comment 4 by zh...@chromium.org, Jan 25 2017

Labels: Pri-1
Cc: majidvp@chromium.org
 Issue 691056  has been merged into this issue.
Cc: nedngu...@google.com skyos...@chromium.org
Adding benchmark owner (skyostil@) and Ned. I ran this benchmark locally, and it works fine (not always an indicator that it will work on the waterfall). We have had it disabled for 2 months now and no one has done anything about it or even posted on this bug. Is this benchmark cared about? If so I will reenable it and watch it to make sure that it is passing on these bots.

It is disabled on other platforms as well.
https://cs.chromium.org/chromium/src/tools/perf/benchmarks/smoothness.py?q=smoothness.py+package:%5Echromium$&l=521

Cc: charliea@chromium.org
+Charlie who was looking at consolidating some of our benchmarks. I'd be fine with replacing this with system health equivalents, but there was some concern whether we have enough ad coverage there. 
Right now, I'm mainly focused on consolidation of power cases, but will very likely be looking at other benchmarks in the future.
Cc: benjhayden@chromium.org
 Issue 666085  has been merged into this issue.
Owner: skyos...@chromium.org
Sami: can we just remove this benchmark? It has been stale for a while now.
Cc: rmcilroy@chromium.org
+Ross who was recently after some ad-heavy content for benchmarks.
Ping Sami: can we just remove this benchmark for now?
NextAction: 2017-07-19
Ping Sami again.  Please help me find someone who can work on reviving this benchmark or we need remove this to reduce technical debt a week from now.
The NextAction date has arrived: 2017-07-19
Owner: nedngu...@google.com
I will make a CL to remove this benchmark.
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c94bfd85af86cc4483b9d9d659a488f5e911e4c0

commit c94bfd85af86cc4483b9d9d659a488f5e911e4c0
Author: nednguyen <nednguyen@google.com>
Date: Tue Jul 25 20:30:45 2017

Remove smoothness.scrolling_tough_ad_cases benchmark

This benchmark has been failing on all platforms for a while and we don't have
bandwidth to revive it.

Bug:  683247 
Change-Id: I57280d16f43403cd3447c7c1f315e3084e6c4aa1
Reviewed-on: https://chromium-review.googlesource.com/578107
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489416}
[modify] https://crrev.com/c94bfd85af86cc4483b9d9d659a488f5e911e4c0/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/c94bfd85af86cc4483b9d9d659a488f5e911e4c0/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/c94bfd85af86cc4483b9d9d659a488f5e911e4c0/tools/perf/benchmark.csv
[modify] https://crrev.com/c94bfd85af86cc4483b9d9d659a488f5e911e4c0/tools/perf/benchmarks/smoothness.py
[modify] https://crrev.com/c94bfd85af86cc4483b9d9d659a488f5e911e4c0/tools/perf/page_sets/tough_ad_cases.py

Blocking: 575762
Status: Fixed (was: Started)

Sign in to add a comment