"SyncErrorTest.ClientDataObsoleteTest" is flaky |
||||||||
Issue description"SyncErrorTest.ClientDataObsoleteTest" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRTeW5jRXJyb3JUZXN0LkNsaWVudERhdGFPYnNvbGV0ZVRlc3QM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jan 23 2017
Pavel, could this have also been caused by http://crrev.com/2641523004? Looks like no flakes have occurred since the 20th when it was reverted.
,
Jan 27 2017
Detected 7 new flakes for test/step "SyncErrorTest.ClientDataObsoleteTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRTeW5jRXJyb3JUZXN0LkNsaWVudERhdGFPYnNvbGV0ZVRlc3QM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jan 30 2017
Detected 3 new flakes for test/step "SyncErrorTest.ClientDataObsoleteTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRTeW5jRXJyb3JUZXN0LkNsaWVudERhdGFPYnNvbGV0ZVRlc3QM. This message was posted automatically by the chromium-try-flakes app.
,
Jan 31 2017
Detected 3 new flakes for test/step "SyncErrorTest.ClientDataObsoleteTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRTeW5jRXJyb3JUZXN0LkNsaWVudERhdGFPYnNvbGV0ZVRlc3QM. This message was posted automatically by the chromium-try-flakes app.
,
Feb 1 2017
Disabling this test on Linux and Windows builders.
,
Feb 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cc54f5575d095142cbc1755653265565a2f462c commit 5cc54f5575d095142cbc1755653265565a2f462c Author: iclelland <iclelland@chromium.org> Date: Wed Feb 01 16:17:14 2017 Disable flaky test SyncErrorTest.ClientDataObsoleteTest. The test has been flaky recently on Linux and Windows builders. Disabling until the root cause is fixed. BUG= 683216 TBR=pavely@chromium.org Review-Url: https://codereview.chromium.org/2668583007 Cr-Commit-Position: refs/heads/master@{#447527} [modify] https://crrev.com/5cc54f5575d095142cbc1755653265565a2f462c/chrome/browser/sync/test/integration/sync_errors_test.cc
,
Feb 1 2017
Detected 5 new flakes for test/step "SyncErrorTest.ClientDataObsoleteTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRTeW5jRXJyb3JUZXN0LkNsaWVudERhdGFPYnNvbGV0ZVRlc3QM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Feb 2 2017
,
Feb 2 2017
There is a race condition that happens when DataTypeManagerImpl is stopped during configuration. In this case Configuration sync cycle can be called with model types that were just unregistered from ModelTypeRegistry. Here is the sequence: [UI thread] - DTMI::Configure posts ModelTypeRegistry::RegisterDirectoryType to sync thread [UI thread] - DTMI::Configure posts SyncBackendHostCore::DoConfigureSyncer to sync thread [UI thread] - DTMI::Stop posts ModelTypeRegistry::UnregisterDirectoryType to sync thread [Sync thread] - ModelTypeRegistry::RegisterDirectoryType creates update handler for type [Sync thread] - SyncBackendHostCore::DoConfigureSyncer posts SyncSchedulerImpl::TrySyncCycleJobImpl on sync thread passing set of types to configure [Sync thread] - ModelTypeRegistry::UnregisterDirectoryType removes update handler [Sync thread] - SyncSchedulerImpl::TrySyncCycleJobImpl runs configuration for the type for which update handler was just unregistered
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2010aad1ee6e6b1edfff8e726dbfbea20c2a6ce4 commit 2010aad1ee6e6b1edfff8e726dbfbea20c2a6ce4 Author: pavely <pavely@chromium.org> Date: Fri Feb 24 21:35:55 2017 [Sync] Adjust types to configure during shutdown When preparing request to server we need to make sure there are update handlers registered for all types to download. It is possible that configuration cycle is scheduled with set of types that are later unregistered from ModelTypeRegistry as part of shutdown. When configuration cycle gets to run it DCHECKs on types that were requested but later unregistered. The solution is to detect shutdown condition and adjust types to download. BUG= 683216 R=skym@chromium.org Review-Url: https://codereview.chromium.org/2718533003 Cr-Commit-Position: refs/heads/master@{#452932} [modify] https://crrev.com/2010aad1ee6e6b1edfff8e726dbfbea20c2a6ce4/chrome/browser/sync/test/integration/sync_errors_test.cc [modify] https://crrev.com/2010aad1ee6e6b1edfff8e726dbfbea20c2a6ce4/components/sync/engine_impl/syncer.cc [modify] https://crrev.com/2010aad1ee6e6b1edfff8e726dbfbea20c2a6ce4/components/sync/engine_impl/syncer_unittest.cc
,
Feb 24 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by waff...@chromium.org
, Jan 23 2017Labels: -Sheriff-Chromium
Owner: maxbogue@chromium.org
Status: Assigned (was: Untriaged)