New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 683215 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Mar 2018
Cc:
akes...@chromium.org
█ jrbarnette@chromium.org
pprabhu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DHCP Character Limit

Project Member Reported by jashur@chromium.org, Jan 20 2017 
Not sure if this is new but I came across an error saying there is a 80 character limit per line?

I have had older entries that are well over 80 characters and I can't make cl changes to match the standard naming structure in our lab.

jashur@jashur:~/lab/chromeos-admin/puppet/modules/lab/files/dhcp-server$ repo upload .
Run hook scripts from https://chrome-internal.googlesource.com/chromeos/manifest-internal.git (yes/always/NO)? yes

Errors in PROJECT *chromeos/chromeos-admin*!
    COMMIT d931a35c:
        Description:
            >Added macs for misc. devices in row3-rack3
            >
            >BUG=b:34395555
            >TEST=presubmit passes
            >
            >Change-Id: I2f24e6cd0c13fdb6f431592bb7b1f919c6e02b86
            >
            >
        Errors:
            * The first line cannot be more than one sentence.
            * Found lines longer than 80 characters (first 5 shown):
                * /usr/local/google/home/jashur/lab/chromeos-admin/puppet/modules/lab/files/dhcp-server/dhcpd.conf, line 12160, 83 chars
                * /usr/local/google/home/jashur/lab/chromeos-admin/puppet/modules/lab/files/dhcp-server/dhcpd.conf, line 12161, 86 chars
                * /usr/local/google/home/jashur/lab/chromeos-admin/puppet/modules/lab/files/dhcp-server/dhcpd.conf, line 12167, 83 chars
                * /usr/local/google/home/jashur/lab/chromeos-admin/puppet/modules/lab/files/dhcp-server/dhcpd.conf, line 12168, 86 chars
                * /usr/local/google/home/jashur/lab/chromeos-admin/puppet/modules/lab/files/dhcp-server/dhcpd.conf, line 12174, 85 chars

Comment 1 by dshi@chromium.org, Jan 20 2017

Components: Infra>Client>ChromeOS
Labels: Hotlist-Fixit
Yeah, the lint check shouldn't be applied to dhcpd.conf. you can ignore that for now. upload with --no-verify

Comment 2 by jashur@chromium.org, Jan 20 2017 

Sounds good, thanks!

Comment 3 by dshi@chromium.org, Jan 23 2017

Cc: akes...@chromium.org
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Untriaged)

Comment 4 by jashur@chromium.org, Mar 7 2017 

Ran into this again. I'll upload with --no-verify

This isn't blocking anything so it's not a high priority, but will this ever be fixed/modified or will this just be the norm?

Thanks,

Joe

Comment 5 by pprabhu@chromium.org, Mar 7 2017 

Work involved:
- Currently, the repohook for long_line_check doesn't have an option to exclude specific files.
  - See an example where such a flag exists (chromiumos licence header check): http://shortn/_BjbvcZYTi9
  - The function for long_line_check doesn't except such an option: http://shortn/_05CcOaKLKp

Then, add a [Hook Overrides Options] section to the PRESUBMIT.cfg in chromeos-admin ignoring .*/dhcp.config

This is indeed a fixit sized bug. So, watch out for the next fixit :)
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 8 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by jashur@chromium.org, Mar 8 2018

Status: WontFix (was: Untriaged)
It's probably not going to be fixed. I just skip the verification and use --no-verify

Thanks,
Joe
►

Sign in to add a comment