New issue
Advanced search Search tips

Issue 683209 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 355145



Sign in to add a comment

PasswordManagerBrowserTestBase.SameOriginIframeAutoFillTest is flaky

Project Member Reported by waff...@chromium.org, Jan 20 2017

Issue description

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56653

PasswordManagerBrowserTestBase.SameOriginIframeAutoFillTest (run #1):
[ RUN      ] PasswordManagerBrowserTestBase.SameOriginIframeAutoFillTest
[4148:1660:0120/084030.792:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported.
[1536:2088:0120/084033.531:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
c:\c\win\src\chromerowser\password_manager\password_manager_test_base.cc(288): error: Value of: return_value
  Actual: false
Expected: true
element_id = password_field, expected_value =
[1536:5252:0120/084036.210:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] PasswordManagerBrowserTestBase.SameOriginIframeAutoFillTest, where TypeParam =  and GetParam() =  (6435 ms)
 
Owner: kenrb@chromium.org
Status: Assigned (was: Untriaged)
I suspect 65c7df6e695eb4435ccf5485498b34fd1629f898 based on:
* Test pass rate was 95%+ until https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)/builds/56635
* Pass rate was <40% after
* This CL seems to touch something about iframes.

kenrb, can you take a look?

Comment 2 by kenrb@chromium.org, Jan 20 2017

Cc: vabr@chromium.org gcasto@chromium.org
Owner: ----
Status: Available (was: Assigned)
I don't really know anything about the password manager, and my CL is related to scrolling in Blink so if it is responsible for increasing the flakiness then that is an incidental fluke.

cc'ing a couple of people who might be better qualified to look at that test.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1aef21baa7ff1a460300cb692fa0247723397c4

commit a1aef21baa7ff1a460300cb692fa0247723397c4
Author: sebsg <sebsg@chromium.org>
Date: Fri Jan 20 23:16:56 2017

[Flake] Disabled SameOriginIframeAutoFillTest on Win7.

Disabled PasswordManagerBrowserTestBase.SameOriginIframeAutoFillTest on
Win7.

BUG= 683209 
TBR=vabr@chromium.org

Review-Url: https://codereview.chromium.org/2646793007
Cr-Commit-Position: refs/heads/master@{#445205}

[modify] https://crrev.com/a1aef21baa7ff1a460300cb692fa0247723397c4/chrome/browser/password_manager/password_manager_browsertest.cc

Labels: -Hotlist-Sheriff-Chromium
Owner: vabr@chromium.org
Passing to vabr@ to triage; moving out of sheriff queue.
Owner: gcasto@chromium.org
er, gcasto due to vabr's OOO

Comment 6 by vabr@chromium.org, Jan 27 2017

Blocking: 355145
Cc: -gcasto@chromium.org -vabr@chromium.org
Components: UI>Browser>Passwords
Labels: Hotlist-TechnicalDebt
Owner: ----
Moving to the triaging queue and linking to our umbrella bug for flaky tests.

(gcasto@ left the team some time ago, so also removing him from owner and Cc fields.)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/331224fb38ef3a2ef7bcc5eadb7592a0bebd0d02

commit 331224fb38ef3a2ef7bcc5eadb7592a0bebd0d02
Author: vasilii <vasilii@chromium.org>
Date: Thu Mar 23 22:23:20 2017

Enable PasswordManagerBrowserTestBase.SameOriginIframeAutoFillTest to get more data

Currently we know that password_field.value was not expected. The CL changes CheckElementValue() so that it outputs more data for all the password tests.
Flakiness in the test may even signify a real bug.

BUG= 683209 

Review-Url: https://codereview.chromium.org/2776513002
Cr-Commit-Position: refs/heads/master@{#459254}

[modify] https://crrev.com/331224fb38ef3a2ef7bcc5eadb7592a0bebd0d02/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/331224fb38ef3a2ef7bcc5eadb7592a0bebd0d02/chrome/browser/password_manager/password_manager_test_base.cc

The test so far is 100% green on Win.
Owner: vasi...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment