WebClient::CreateWebMainParts() should return std::unique_ptr<> |
||||||
Issue descriptionTo make ownership clear, WebClient::CreateWebMainParts() should return a std::unique_ptr<> since the returned value is held in a unique_ptr<> in web_main_loop.
,
Jan 24 2017
This has been started here: https://codereview.chromium.org/2647943004/ However, I was blocked by a dependency cycle that was not easy to break when adding the import to ios/web/public/web_client.mm. (The import is needed for unique_ptr.) Instead of //ios/web/app depending on ios/web, it should depend on pieces of //ios/web after it is broken up.
,
Mar 15 2017
,
Apr 13 2017
,
May 31 2017
Looks like this CL fixes the issue: https://chromium-review.googlesource.com/c/519263/
,
Jun 1 2017
You're right, thank you sdefresne! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by michaeldo@chromium.org
, Jan 20 2017Owner: michaeldo@chromium.org
Status: Started (was: Untriaged)