lunalu@, can you PTAL and either revert or add a test expectation in third_party/WebKit/LayoutTests/FlagExpectations/site-per-process?

Looks like this test was added in r444797 ("Initial implementation for feature policy - PaymentRequest") and failed from the start on https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/17660.

Not sure how closely related it is, but there was a fairly recent allowpaymentrequest request CL adding support for out-of-process iframes in r438724.  Would the work done there help with getting this test to pass in --site-per-process mode?

Thanks for taking a look!

Is this passing on Linux site isolation bots? It doesn't look like the CL triggered those trybots before it landed.

I'm trying to reproduce this with

third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default --additional-driver-flag=--enable-blink-features=FeaturePolicy --additional-driver-flag=--site-per-process http/tests/feature-policy/payment-enabledforself.php

and it passes locally on Linux; just checking before I try at the windows lab)

No -- actually, I can reproduce with that command line (after I stashed my local changes, at least); sorry for the noise.

We should probably disable the test in expectations and then fix this.

The Site Isolation Linux bot only runs the http/tests subset of layout tests (i.e. doesn't run tests under virtual/feature-policy).  I have't tried to repro locally yet.  FWIW, your commandline in #c3 looks right to me.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6701954e9d1f4a50a8b80d888748f7ce78ee82a6

commit 6701954e9d1f4a50a8b80d888748f7ce78ee82a6
Author: iclelland <iclelland@chromium.org>
Date: Fri Jan 20 20:56:56 2017

Disable feature-policy/fullscreen-enabledforself.php for site-isolation bots

BUG= 683199 
NOTRY=true
R=lukasza@chromium.org

Review-Url: https://codereview.chromium.org/2644723005
Cr-Commit-Position: refs/heads/master@{#445158}

[modify] https://crrev.com/6701954e9d1f4a50a8b80d888748f7ce78ee82a6/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Thanks for getting the bot green, and for looking into the underlying issue!

It looks the like the root cause of this was that the feature policy header is not being replicated correctly to out-of-process frames. I'm running https://codereview.chromium.org/2644233005/ through the trybots right now, and if it works, it should fix both this and  crbug.com/672546 .

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fafd01c2b16b4c4b23e3fb83c80722f36a3bb14

commit 6fafd01c2b16b4c4b23e3fb83c80722f36a3bb14
Author: iclelland <iclelland@chromium.org>
Date: Tue Jan 24 14:11:55 2017

Fix Feature Policy header replication in site-isolation.

The ToWebParsedFeaturePolicy method was not constructing the
WebParsedFeaturePolicy struct correctly, so remote frames would only receive
empty whitelists when the FP header was replicated from their local process.

BUG= 683199 , 672546 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2644233005
Cr-Commit-Position: refs/heads/master@{#445714}

[modify] https://crrev.com/6fafd01c2b16b4c4b23e3fb83c80722f36a3bb14/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/6fafd01c2b16b4c4b23e3fb83c80722f36a3bb14/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Is this change applicable to All OSes or any specific OS?

The change applies to all Blink platforms, so Windows, Linux, Mac and Android (everything except iOS.)

Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cd339129aa18e64658b1f15f37a53789dab5b68

commit 2cd339129aa18e64658b1f15f37a53789dab5b68
Author: Ian Clelland <iclelland@google.com>
Date: Tue Jan 24 19:18:05 2017

Fix Feature Policy header replication in site-isolation.

The ToWebParsedFeaturePolicy method was not constructing the
WebParsedFeaturePolicy struct correctly, so remote frames would only receive
empty whitelists when the FP header was replicated from their local process.

BUG= 683199 , 672546 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2644233005
Cr-Commit-Position: refs/heads/master@{#445714}
(cherry picked from commit 6fafd01c2b16b4c4b23e3fb83c80722f36a3bb14)

Review-Url: https://codereview.chromium.org/2653043002 .
Cr-Commit-Position: refs/branch-heads/2987@{#66}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/2cd339129aa18e64658b1f15f37a53789dab5b68/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/2cd339129aa18e64658b1f15f37a53789dab5b68/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process