Running ./chrome --mash launches two Chrome browser process |
||||||||||
Issue descriptionIf you run "./chrome --mash" it launches two Chrome browser processes, each with "--process-service-name=content_browser" in the command line and each with their own set of child processes. I've attached a screenshot from htop which shows 114292 and 114268. Both Chrome processes were launched when I ran "./chrome --mash" and both are killed when I kill the service_manager. Each Chrome process has a few child processes but only one has renderers. I can kill the Chrome process without renderers and mustash continues to run. Both Chrome processes create a DBusServices object which is how I noticed this.
,
Jan 20 2017
,
Jan 20 2017
There are a couple of potential problems here: . there is some raciness with how the service_manager gets manifests that may contribute to launching two instances (677194). . If any singleton service (such as ash) connects directly to chrome then chrome is launched with a user id of the singleton (679407). Ken is going to make the browser effectively a singleton, which will fix the second issue. I am aware of one place where ash connects to chrome, if that is it I can comment it out until 679407 is fixed. Let me poke at this.
,
Jan 20 2017
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1340ff2da37b5fcd669e08842cea9223b325a873 commit 1340ff2da37b5fcd669e08842cea9223b325a873 Author: sky <sky@chromium.org> Date: Fri Jan 20 21:30:53 2017 mash: Makes mash and service:ui not establish outgoing connections The ui service was connecting to chrome for the ime driver. As the ui service is a singleton and chrome isn't, this triggered launching another process of chrome, which we don't want. Turns out having ui connect to chrome for the ime driver is unnecessary as chrome already does this. So, removing the code. Mash was connecting to the chrome for the keyboard service. This is also problematic for similar reasons, so removing it too. Filed bug to have chrome register keyboard with mash. BUG= 664267 , 662157 , 664264 , 683192 , 683289 TEST=none R=moshayedi@chromium.org Review-Url: https://codereview.chromium.org/2645683007 Cr-Commit-Position: refs/heads/master@{#445172} [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/ash/mus/BUILD.gn [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/ash/mus/keyboard_ui_mus.cc [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/BUILD.gn [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/ime_server_impl.cc [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/ime_server_impl.h [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/manifest.json
,
Jan 20 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
,
Jun 21 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by kylec...@chromium.org
, Jan 20 2017