Reenable testMixedContentWarning and testMixedContentWarningAfterAddingHTTPImage |
|||||||||||||
Issue descriptionThese tests are failing on all bots downstream. Please reassign priority if you think this is too extreme.
,
Jan 20 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/813b05f6c4237270398ce95bb3097836b76c25dd commit 813b05f6c4237270398ce95bb3097836b76c25dd Author: stkhapugin <stkhapugin@google.com> Date: Fri Jan 20 17:58:33 2017
,
Jan 20 2017
Oliver, is there a reason why this bug was assigned to you? Is it because you landed an upstream change which broke these tests? If you did not touch anything related to SSL then feel free to assign this bug to me.
,
Jan 20 2017
No, I did not land anything. I think stk assigned it to me because I worked on mixed content for offline pages, but this is not related (and was not even landed 2 hours ago).
,
Jan 20 2017
Tests were broken by this CL: https://codereview.chromium.org/2620243005 Assigning to CL author for investigation.
,
Jan 23 2017
,
Jan 23 2017
Thanks for taking a look lgarron@. Please investigate as soon as possible.
,
Jan 23 2017
Oha, I didn't know there were downstream tests like this relying on Page Info. I'll take a stab at updating.
,
Jan 23 2017
How soon do you need this fixed? The tests need to be updated, but the breakage here very probably does not reflect a functional bug. I'm security sheriff until tomorrow, so it I can leave this until then it would be a lot better for me.
,
Jan 23 2017
Claude, can this be RBS instead of RBB?
,
Jan 23 2017
To lgarron@, fixing this tomorrow is fine. To eugenebut@, depending on lgarron@'s assessment after debugging this issue, we might make it an RBS. For now, it should be an RBB.
,
Jan 25 2017
I've been trying on-and-off all day to get the test to run so that I can fix it, and... it hasn't been working. This might need to wait until tomorrow. :-/
,
Jan 25 2017
*woo* builds now
,
Jan 25 2017
CL at https://chromereviews.googleplex.com/559557013 I had some trouble syncing, building, and testing, but the fix is straightforward.
,
Jan 25 2017
Thanks lgarron@
,
Jan 26 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/34e26faaf06a9fb932a0a2f2531143622344e3fc commit 34e26faaf06a9fb932a0a2f2531143622344e3fc Author: lgarron <lgarron@google.com> Date: Thu Jan 26 06:09:24 2017
,
Jan 26 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e5546af0c4b5d6c857b36a2e39d64a738461b361 commit e5546af0c4b5d6c857b36a2e39d64a738461b361 Author: gambard <gambard@google.com> Date: Thu Jan 26 09:40:38 2017
,
Jan 26 2017
,
Jan 26 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 6 2017
Is it worth merging the test fix to M57?
,
Feb 6 2017
No objection!
,
Feb 15 2017
I was more asking whether I can avoid merging. :-P But let's ask.
,
Feb 15 2017
This bug requires manual review: Less than 2 weeks to go before AppStore submit on M57 Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 15 2017
re #24: This is a fix to to a test case. It should not affect behaviour (but should catch issues if for some reason we merge a regression to the thing it tests).
,
Feb 15 2017
:) about comment 23. I caught you! :)
,
Feb 15 2017
Oh, humm. I don't have permissions to merge internal Bling CLs. Could you or eugenebut@ to the honors?
,
Feb 16 2017
There are 2 CLs in this bug. We we need to cherry pick both?
,
Feb 20 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 23 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 11 2017
Well, this is certainly not going into M57 anymore. :-P |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by baxley@chromium.org
, Jan 20 2017