New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683191 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Reenable testMixedContentWarning and testMixedContentWarningAfterAddingHTTPImage

Project Member Reported by stkhapugin@chromium.org, Jan 20 2017

Issue description

These tests are failing on all bots downstream. 

Please reassign priority if you think this is too extreme. 
 

Comment 1 by baxley@chromium.org, Jan 20 2017

Cc: eugene...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/813b05f6c4237270398ce95bb3097836b76c25dd

commit 813b05f6c4237270398ce95bb3097836b76c25dd
Author: stkhapugin <stkhapugin@google.com>
Date: Fri Jan 20 17:58:33 2017

Oliver, is there a reason why this bug was assigned to you? Is it because you landed an upstream change which broke these tests? If you did not touch anything related to SSL then feel free to assign this bug to me.
Cc: -eugene...@chromium.org olivierrobin@chromium.org
Owner: eugene...@chromium.org
No, I did not land anything.
I think stk assigned it to me because I worked on mixed content for offline pages, but this is not related (and was not even landed 2 hours ago).
Cc: eugene...@chromium.org
Owner: lgar...@chromium.org
Tests were broken by this CL: https://codereview.chromium.org/2620243005
Assigning to CL author for investigation.

Comment 6 Deleted

Comment 7 by cma...@chromium.org, Jan 23 2017

Labels: -M-58 M-57

Comment 8 by cma...@chromium.org, Jan 23 2017

Thanks for taking a look lgarron@. Please investigate as soon as possible.
Oha, I didn't know there were downstream tests like this relying on Page Info.
I'll take a stab at updating.
How soon do you need this fixed?

The tests need to be updated, but the breakage here very probably does not reflect a functional bug. I'm security sheriff until tomorrow, so it I can leave this until then it would be a lot better for me.
Cc: cma...@chromium.org
Claude, can this be RBS instead of RBB?
 To lgarron@, fixing this tomorrow is fine. To eugenebut@, depending on lgarron@'s assessment after debugging this issue, we might make it an RBS. For now, it should be an RBB.
I've been trying on-and-off all day to get the test to run so that I can fix it, and... it hasn't been working.
This might need to wait until tomorrow. :-/
Status: Started (was: Assigned)
*woo* builds now
CL at https://chromereviews.googleplex.com/559557013

I had some trouble syncing, building, and testing, but the fix is straightforward.
Thanks lgarron@
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/34e26faaf06a9fb932a0a2f2531143622344e3fc

commit 34e26faaf06a9fb932a0a2f2531143622344e3fc
Author: lgarron <lgarron@google.com>
Date: Thu Jan 26 06:09:24 2017

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e5546af0c4b5d6c857b36a2e39d64a738461b361

commit e5546af0c4b5d6c857b36a2e39d64a738461b361
Author: gambard <gambard@google.com>
Date: Thu Jan 26 09:40:38 2017

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Restrict-View-Google
Is it worth merging the test fix to M57?
No objection!
Labels: -Merge-TBD Merge-Request-57
I was more asking whether I can avoid merging. :-P
But let's ask.
Project Member

Comment 24 by sheriffbot@chromium.org, Feb 15 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Less than 2 weeks to go before AppStore submit on M57
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
re #24: This is a fix to to a test case. It should not affect behaviour (but should catch issues if for some reason we merge a regression to the thing it tests).
Labels: -Hotlist-Merge-Review -Merge-Review-57 Merge-Approved-57
:) about comment 23. I caught you! :)
Oh, humm. I don't have permissions to merge internal Bling CLs. Could you or eugenebut@ to the honors?
There are 2 CLs in this bug. We we need to cherry pick both?
Project Member

Comment 29 by sheriffbot@chromium.org, Feb 20 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 30 by sheriffbot@chromium.org, Feb 23 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-57 -Merge-Approved-57 M-58
Well, this is certainly not going into M57 anymore. :-P

Sign in to add a comment