HTMLCanvasElement with OffscreenCanvas, must handle Document re-parenting |
||
Issue descriptionWhen a <canvas> Element is moved from one document to another, the Frame also changes, meaning that the SurfaceLayer may need to be re-hooked. We need to make sure that OffscreenCanvas commits are still functional when the canvas is in frame-less document. The canvas may not be visible on screen, but it should still be possible to use the canvas as an image source. We also need to make sure that canvases remain functional after being moved between documents. For example when a canvas from a frame-less document is moved to a document with a frame, all necessary conection must be made to establish the BeginFrame signal so that the Promises returned by commit() get resolved as expected. This is a rare use case that does not need to be fixed before shipping OffscreenCanvas.
,
May 11 2018
As discussed in team meeting, this issue is archived.
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7b306efe243686c1ce81ced20c04a31dd9d2e20 commit a7b306efe243686c1ce81ced20c04a31dd9d2e20 Author: xlai <xlai@chromium.org> Date: Fri May 11 20:34:40 2018 No handling of frame-less canvas element for OffscreenCanvas As this use case is too small to be worth the effort, we archive this task and modify comments. TBR=junov@chromium.org Bug: 683172 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic1f55ed6c5a8b7ae074f7e03b8c07fa1bc7a4815 Reviewed-on: https://chromium-review.googlesource.com/1055814 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#558007} [modify] https://crrev.com/a7b306efe243686c1ce81ced20c04a31dd9d2e20/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-frameless-doc.html [modify] https://crrev.com/a7b306efe243686c1ce81ced20c04a31dd9d2e20/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc [modify] https://crrev.com/a7b306efe243686c1ce81ced20c04a31dd9d2e20/third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc |
||
►
Sign in to add a comment |
||
Comment 1 by xlai@chromium.org
, May 11 2018Labels: OffScreenCanvas