New issue
Advanced search Search tips

Issue 683156 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug-Security



Sign in to add a comment

Security: Signed Integer Overflow in pdfium (openjpeg)

Reported by c...@ecraig.com, Jan 20 2017

Issue description

VULNERABILITY DETAILS
A signed integer overflow exists in openjpeg code for determining tile counts.  I have provided a few examples to show different resulting code paths but I have not confirmed if this can be used to influence code execution.

The testcases should all hit the same underlying problem but demonstrate different resulting overflows.

VERSION
Chrome Version: ubsan-linux-release-444724.zip (pdfium_test)
Operating System: Ubuntu Linux 16.04

REPRODUCTION CASE
I have attached pdf inputs and pdfium_test outputs in a tgz.
 
pdfium_ubsan_overflows.tgz
2.2 KB Download

Comment 1 by tsepez@chromium.org, Jan 20 2017

Owner: dsinclair@chromium.org
Project Member

Comment 2 by sheriffbot@chromium.org, Jan 21 2017

Status: Assigned (was: Unconfirmed)

Comment 3 by c...@ecraig.com, Jan 23 2017

Would it be possible to get Hanno Böck CC'd on this bug report?  He was involved in getting a PDF testcase and is interested to see the process when submitting a UBSAN detected bug that has not been confirmed as security relevant. 

Hanno has contact information here in case you are unfamiliar: https://hboeck.de/en/contact.html
Cc: dsinclair@chromium.org
Owner: npm@chromium.org
Project Member

Comment 5 by ClusterFuzz, Jan 24 2017

ClusterFuzz is analyzing your testcase. Developers can follow the progress at https://cluster-fuzz.appspot.com/testcase?key=5152891347402752
Project Member

Comment 6 by ClusterFuzz, Jan 24 2017

ClusterFuzz is analyzing your testcase. Developers can follow the progress at https://cluster-fuzz.appspot.com/testcase?key=4563437855440896
Project Member

Comment 7 by ClusterFuzz, Jan 24 2017

ClusterFuzz is analyzing your testcase. Developers can follow the progress at https://cluster-fuzz.appspot.com/testcase?key=5432625687953408

Comment 9 by palmer@chromium.org, Jan 24 2017

Cc: tsepez@chromium.org
Components: Internals>Plugins>PDF
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Something to nail down: whether or not this is a bug in OpenJPEG, or in PDFium's usage of that library. If it's in OpenJPEG, we'll need to report it to upstream, too.

+tsepez from security.

Comment 11 by c...@ecraig.com, Jan 24 2017

This was found initially by fuzzing a tool from OpenJPEG so it should be reported upstream. 
Labels: Security_Severity-Low Security_Impact-Stable
Tentatively assigning low severity since it's not clear if this is exploitable.

Comment 13 by npm@chromium.org, Jan 24 2017

Status: Started (was: Assigned)
Reported upstream[1], and CL up for review[2].
[1] https://github.com/uclouvain/openjpeg/issues/889
[2] https://pdfium-review.googlesource.com/c/2353/
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b111b29a9371dd08dc96c6d72961fc23d3665b0

commit 1b111b29a9371dd08dc96c6d72961fc23d3665b0
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Wed Jan 25 05:18:20 2017

Roll src/third_party/pdfium/ 33316fccc..d198e406d (1 commit).

https://pdfium.googlesource.com/pdfium.git/+log/33316fccc6a5..d198e406d13b

$ git log 33316fccc..d198e406d --date=short --no-merges --format='%ad %ae %s'
2017-01-24 npm Use opj_uint_ceildiv where it is better than its int version

BUG= 683156 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2649923014
Cr-Commit-Position: refs/heads/master@{#445956}

[modify] https://crrev.com/1b111b29a9371dd08dc96c6d72961fc23d3665b0/DEPS

Project Member

Comment 15 by sheriffbot@chromium.org, Jan 25 2017

Labels: Pri-2
Project Member

Comment 18 by ClusterFuzz, Jan 25 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5152891347402752 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 19 by sheriffbot@chromium.org, Jan 26 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 20 by sheriffbot@chromium.org, May 4 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment