WebViewLayoutTest.testWebViewIncludedStableInterfaces disabled after blink layout test rebaseline |
|||||
Issue description//third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt was moved in https://codereview.chromium.org/2642873002, but webview's use of it was not updated. This is causing failures on the webview bots starting with: - https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20L%20%28dbg%29/builds/1370 - https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20M%20%28dbg%29/builds/1370
,
Jan 20 2017
,
Jan 20 2017
,
Jan 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/170fe4f55dd622189fdb5ade13301e996149e076 commit 170fe4f55dd622189fdb5ade13301e996149e076 Author: jbudorick <jbudorick@chromium.org> Date: Sat Jan 21 01:22:20 2017 Disable WebViewLayoutTest.testWebViewExcludedInterfaces. BUG= 683153 TBR=timvolodine@chromium.org Review-Url: https://codereview.chromium.org/2644463010 Cr-Commit-Position: refs/heads/master@{#445238} [modify] https://crrev.com/170fe4f55dd622189fdb5ade13301e996149e076/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java
,
Jan 26 2017
Patch to re-enable testWebViewExcludedInterfaces in flight https://codereview.chromium.org/2658923002/ The testWebViewIncludedStableInterfaces is harder because apparently https://codereview.chromium.org/2642873002 deleted the stable interfaces file we relied on. Will need to dig a bit more as to what is happening with the stable interfaces..
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3688ba478b1992affc20ec3209efe7fef9577be commit d3688ba478b1992affc20ec3209efe7fef9577be Author: timvolodine <timvolodine@chromium.org> Date: Fri Jan 27 16:34:30 2017 [SystemWebViewLayoutTest] Update expectations and re-enable testWebViewExcludedInterfaces. Update non-exposed interfaces and re-enable broken test, due to https://codereview.chromium.org/2642873002 non exposed attributes: attribute mojo -> attribute gin BUG= 683153 TBR=tobiasjs@chromium.org Review-Url: https://codereview.chromium.org/2658923002 Cr-Commit-Position: refs/heads/master@{#446683} [modify] https://crrev.com/d3688ba478b1992affc20ec3209efe7fef9577be/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java [modify] https://crrev.com/d3688ba478b1992affc20ec3209efe7fef9577be/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4965734c3a73e6fc608071eba416e9af6b83555d commit 4965734c3a73e6fc608071eba416e9af6b83555d Author: timvolodine <timvolodine@chromium.org> Date: Wed Feb 15 18:30:35 2017 [WebViewLayoutTest] Implement a fallback mechanism and re-enable testWebViewIncludedStableInterfaces. Implement a 'fallback' mechanism for the selection of appropriate global interfaces file to compare with. The approach checks a number of files in the list to determine which one to use. Due to the nature of rebaselining in blink the suitable virtual/stable/webexposed/ global-interface-listing-expected.txt can be located in a number of places and can change dynamically. This patch also enables the testWebViewIncludedStableInterfaces test which was previously disabled due to the above issue. BUG= 683153 , 506603 ,497861 Review-Url: https://codereview.chromium.org/2684313002 Cr-Commit-Position: refs/heads/master@{#450743} [modify] https://crrev.com/4965734c3a73e6fc608071eba416e9af6b83555d/android_webview/tools/system_webview_shell/BUILD.gn [modify] https://crrev.com/4965734c3a73e6fc608071eba416e9af6b83555d/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4617c896b2b96fbbb22f14c0f6626bbf4cb0aff6 commit 4617c896b2b96fbbb22f14c0f6626bbf4cb0aff6 Author: wychen <wychen@chromium.org> Date: Wed Feb 15 21:39:51 2017 Revert of [WebViewLayoutTest] Implement a fallback mechanism and re-enable testWebViewIncludedStableInterface… (patchset #3 id:40001 of https://codereview.chromium.org/2684313002/ ) Reason for revert: Break SystemWebViewShellLayoutTest.SystemWebViewShellLayoutTest on WebView bots https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20WebView%20L%20%28dbg%29/builds/2200 https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20WebView%20M%20%28dbg%29/builds/2200 Original issue's description: > [WebViewLayoutTest] Implement a fallback mechanism and re-enable testWebViewIncludedStableInterfaces. > > Implement a 'fallback' mechanism for the selection of appropriate > global interfaces file to compare with. The approach checks a number > of files in the list to determine which one to use. Due to the nature > of rebaselining in blink the suitable virtual/stable/webexposed/ > global-interface-listing-expected.txt can be located in a number of > places and can change dynamically. > > This patch also enables the testWebViewIncludedStableInterfaces test > which was previously disabled due to the above issue. > > BUG= 683153 , 506603 ,497861 > > Review-Url: https://codereview.chromium.org/2684313002 > Cr-Commit-Position: refs/heads/master@{#450743} > Committed: https://chromium.googlesource.com/chromium/src/+/4965734c3a73e6fc608071eba416e9af6b83555d TBR=torne@chromium.org,tobiasjs@chromium.org,timvolodine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 683153 , 506603 ,497861 Review-Url: https://codereview.chromium.org/2694283007 Cr-Commit-Position: refs/heads/master@{#450812} [modify] https://crrev.com/4617c896b2b96fbbb22f14c0f6626bbf4cb0aff6/android_webview/tools/system_webview_shell/BUILD.gn [modify] https://crrev.com/4617c896b2b96fbbb22f14c0f6626bbf4cb0aff6/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/558119e51b5c263536897d096ee5e62f852cddca commit 558119e51b5c263536897d096ee5e62f852cddca Author: timvolodine <timvolodine@chromium.org> Date: Thu Feb 16 21:21:16 2017 [WebViewLayoutTest] Implement a fallback mechanism and re-enable testWebViewIncludedStableInterfaces. Implement a 'fallback' mechanism for the selection of appropriate global interfaces file to compare with. The approach checks a number of files in the list to determine which one to use. Due to the nature of rebaselining in blink the suitable virtual/stable/webexposed/ global-interface-listing-expected.txt can be located in a number of places and can change dynamically. This patch also enables the testWebViewIncludedStableInterfaces test which was previously disabled due to the above issue. BUG= 683153 , 506603 ,497861 NOTRY=true Review-Url: https://codereview.chromium.org/2684313002 Cr-Original-Commit-Position: refs/heads/master@{#450743} Committed: https://chromium.googlesource.com/chromium/src/+/4965734c3a73e6fc608071eba416e9af6b83555d Review-Url: https://codereview.chromium.org/2684313002 Cr-Commit-Position: refs/heads/master@{#451100} [modify] https://crrev.com/558119e51b5c263536897d096ee5e62f852cddca/android_webview/tools/system_webview_shell/BUILD.gn [modify] https://crrev.com/558119e51b5c263536897d096ee5e62f852cddca/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java
,
Feb 26 2017
this is fixed, android webview bots are green and happy https://build.chromium.org/p/chromium.android/waterfall
,
Feb 26 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jan 20 2017