New issue
Advanced search Search tips

Issue 683143 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Protobuf library GNI doen't let importing from outside directories

Project Member Reported by rhalavati@chromium.org, Jan 20 2017

Issue description

Protobuf library's GNI doesn't let BUILD.gn define directories outside the base directory of the source files to be used for importing proto files in source protofiles. This can be resolved by adding an extra optional parameter that specifies the directories from which proto files are imported.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c4b1788e3e0010560d6a064433f4f99afae5fda

commit 0c4b1788e3e0010560d6a064433f4f99afae5fda
Author: rhalavati <rhalavati@chromium.org>
Date: Tue Feb 14 10:00:24 2017

Option added to protobuf build for import directories

Protobuf library GNI does not let BUILD.gn define directories outside the base directory of the source files to be used for importing proto files in source proto files. This is resolved by adding an extra optional parameter that specifies the directories from which proto files are imported.

BUG= 683143 

Review-Url: https://codereview.chromium.org/2646123002
Cr-Commit-Position: refs/heads/master@{#450309}

[modify] https://crrev.com/0c4b1788e3e0010560d6a064433f4f99afae5fda/third_party/protobuf/proto_library.gni
[modify] https://crrev.com/0c4b1788e3e0010560d6a064433f4f99afae5fda/tools/protoc_wrapper/protoc_wrapper.py

Status: Fixed (was: Started)

Sign in to add a comment