factory: new "No disk space" without TTY |
|||||||||
Issue descriptionChrome Version: ToT OS: Chrome What steps will reproduce the problem? (1) fill out /var or /var/factory (2) reboot What is the expected result? See some "no disk space" message What happens instead? blank screen The "no disk space" warning used to work, but the mighty frecon just breaks it. We have no easy way to do chvt/ get vt (unless we change the boot-splash to pre-create VTs). Pending on Frecon is dangerous. Chrome seem to still able to boot even if disk is full, so let's try displaying no-disk-space message in Chrome.
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/2b7e6b8780b4ccd32129286544a5ec433dba98f3 commit 2b7e6b8780b4ccd32129286544a5ec433dba98f3 Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Jan 20 12:08:54 2017 goofy: Make "no disk space" message available on Chrome. The no-disk-space warning on TTY was dead since Frecon was introduced. There's no easy way to do switch-vt, request-for-vt in post-startup time, so we need some other approach to notify operators that disk is full. Fortunately, Chrome seems working happily even if /var and /usr/local are both full - although it may show some profile error. This change tries to: - Use Chrome to display no-disk-space message. - Improve disk_space.py to provide more precise & meaningful disk info. - Mount /var/tmp as tmpfs so Chrome won't pop profile error on disk full. BUG= chromium:683117 TEST=make toolkit; dd if=/dev/zero of=/var/garbage bs=50M; dd if=/dev/zero of=/var/factory/garbage bs=50M; install toolkit and reboot, seeing error messages on Chrome window. Change-Id: I64f7a9a6ef7bac0cb4ae3aa83e0ca46b94325774 Reviewed-on: https://chromium-review.googlesource.com/430436 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/2b7e6b8780b4ccd32129286544a5ec433dba98f3/py/tools/disk_space.py [add] https://crrev.com/2b7e6b8780b4ccd32129286544a5ec433dba98f3/misc/no_space.html [modify] https://crrev.com/2b7e6b8780b4ccd32129286544a5ec433dba98f3/init/goofy.d/presenter/setup_chrome.sh [modify] https://crrev.com/2b7e6b8780b4ccd32129286544a5ec433dba98f3/sh/goofy_control.sh
,
Jan 24 2017
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/56f92c5588f5939ff9eacc7a2f4616bb8ff9504e commit 56f92c5588f5939ff9eacc7a2f4616bb8ff9504e Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Jan 20 12:08:54 2017 goofy: Make "no disk space" message available on Chrome. The no-disk-space warning on TTY was dead since Frecon was introduced. There's no easy way to do switch-vt, request-for-vt in post-startup time, so we need some other approach to notify operators that disk is full. Fortunately, Chrome seems working happily even if /var and /usr/local are both full - although it may show some profile error. This change tries to: - Use Chrome to display no-disk-space message. - Improve disk_space.py to provide more precise & meaningful disk info. - Mount /var/tmp as tmpfs so Chrome won't pop profile error on disk full. BUG= chromium:683117 TEST=make toolkit; dd if=/dev/zero of=/var/garbage bs=50M; dd if=/dev/zero of=/var/factory/garbage bs=50M; install toolkit and reboot, seeing error messages on Chrome window. Change-Id: I64f7a9a6ef7bac0cb4ae3aa83e0ca46b94325774 Reviewed-on: https://chromium-review.googlesource.com/430436 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> (cherry picked from commit 2b7e6b8780b4ccd32129286544a5ec433dba98f3) Reviewed-on: https://chromium-review.googlesource.com/432140 Reviewed-by: Youcheng Syu <youcheng@google.com> Commit-Queue: Youcheng Syu <youcheng@google.com> Tested-by: Youcheng Syu <youcheng@google.com> [modify] https://crrev.com/56f92c5588f5939ff9eacc7a2f4616bb8ff9504e/py/tools/disk_space.py [add] https://crrev.com/56f92c5588f5939ff9eacc7a2f4616bb8ff9504e/misc/no_space.html [modify] https://crrev.com/56f92c5588f5939ff9eacc7a2f4616bb8ff9504e/init/goofy.d/presenter/setup_chrome.sh [modify] https://crrev.com/56f92c5588f5939ff9eacc7a2f4616bb8ff9504e/sh/goofy_control.sh
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/007a549922daf266eddc49b044d0c1b9bb40ed1a commit 007a549922daf266eddc49b044d0c1b9bb40ed1a Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Jan 20 12:08:54 2017 goofy: Make "no disk space" message available on Chrome. The no-disk-space warning on TTY was dead since Frecon was introduced. There's no easy way to do switch-vt, request-for-vt in post-startup time, so we need some other approach to notify operators that disk is full. Fortunately, Chrome seems working happily even if /var and /usr/local are both full - although it may show some profile error. This change tries to: - Use Chrome to display no-disk-space message. - Improve disk_space.py to provide more precise & meaningful disk info. - Mount /var/tmp as tmpfs so Chrome won't pop profile error on disk full. BUG= chromium:683117 TEST=make toolkit; dd if=/dev/zero of=/var/garbage bs=50M; dd if=/dev/zero of=/var/factory/garbage bs=50M; install toolkit and reboot, seeing error messages on Chrome window. Change-Id: I64f7a9a6ef7bac0cb4ae3aa83e0ca46b94325774 Reviewed-on: https://chromium-review.googlesource.com/430436 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> (cherry picked from commit 2b7e6b8780b4ccd32129286544a5ec433dba98f3) Reviewed-on: https://chromium-review.googlesource.com/432142 Commit-Queue: Hung-Te Lin <hungte@chromium.org> Trybot-Ready: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/007a549922daf266eddc49b044d0c1b9bb40ed1a/py/tools/disk_space.py [add] https://crrev.com/007a549922daf266eddc49b044d0c1b9bb40ed1a/misc/no_space.html [modify] https://crrev.com/007a549922daf266eddc49b044d0c1b9bb40ed1a/init/goofy.d/presenter/setup_chrome.sh [modify] https://crrev.com/007a549922daf266eddc49b044d0c1b9bb40ed1a/sh/goofy_control.sh
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/50a5866f6785fa2c7ec993cdddb9500a6c27008a commit 50a5866f6785fa2c7ec993cdddb9500a6c27008a Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Jan 20 12:08:54 2017 goofy: Make "no disk space" message available on Chrome. The no-disk-space warning on TTY was dead since Frecon was introduced. There's no easy way to do switch-vt, request-for-vt in post-startup time, so we need some other approach to notify operators that disk is full. Fortunately, Chrome seems working happily even if /var and /usr/local are both full - although it may show some profile error. This change tries to: - Use Chrome to display no-disk-space message. - Improve disk_space.py to provide more precise & meaningful disk info. - Mount /var/tmp as tmpfs so Chrome won't pop profile error on disk full. BUG= chromium:683117 TEST=make toolkit; dd if=/dev/zero of=/var/garbage bs=50M; dd if=/dev/zero of=/var/factory/garbage bs=50M; install toolkit and reboot, seeing error messages on Chrome window. Change-Id: I64f7a9a6ef7bac0cb4ae3aa83e0ca46b94325774 Reviewed-on: https://chromium-review.googlesource.com/430436 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> (cherry picked from commit 2b7e6b8780b4ccd32129286544a5ec433dba98f3) Reviewed-on: https://chromium-review.googlesource.com/432143 Commit-Queue: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/50a5866f6785fa2c7ec993cdddb9500a6c27008a/py/tools/disk_space.py [add] https://crrev.com/50a5866f6785fa2c7ec993cdddb9500a6c27008a/misc/no_space.html [modify] https://crrev.com/50a5866f6785fa2c7ec993cdddb9500a6c27008a/init/goofy.d/presenter/setup_chrome.sh [modify] https://crrev.com/50a5866f6785fa2c7ec993cdddb9500a6c27008a/sh/goofy_control.sh
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/73233b4e03d08b3162380b146ee0e0ab0ff841ce commit 73233b4e03d08b3162380b146ee0e0ab0ff841ce Author: Jongpil Jung <jongpil19.jung@samsung.com> Date: Wed Feb 22 01:00:13 2017 Revert "goofy: Make "no disk space" message available on Chrome." This reverts commit 50a5866f6785fa2c7ec993cdddb9500a6c27008a. Reason for revert: Wipe in place is broken on glados factory branch. Original change's description: > goofy: Make "no disk space" message available on Chrome. > > The no-disk-space warning on TTY was dead since Frecon was introduced. > There's no easy way to do switch-vt, request-for-vt in post-startup > time, so we need some other approach to notify operators that disk is > full. > > Fortunately, Chrome seems working happily even if /var and /usr/local > are both full - although it may show some profile error. > > This change tries to: > - Use Chrome to display no-disk-space message. > - Improve disk_space.py to provide more precise & meaningful disk info. > - Mount /var/tmp as tmpfs so Chrome won't pop profile error on disk full. > > BUG= chromium:683117 > TEST=make toolkit; > dd if=/dev/zero of=/var/garbage bs=50M; > dd if=/dev/zero of=/var/factory/garbage bs=50M; > install toolkit and reboot, seeing error messages on Chrome window. > > Change-Id: I64f7a9a6ef7bac0cb4ae3aa83e0ca46b94325774 > Reviewed-on: https://chromium-review.googlesource.com/430436 > Commit-Ready: Hung-Te Lin <hungte@chromium.org> > Tested-by: Hung-Te Lin <hungte@chromium.org> > Reviewed-by: Hung-Te Lin <hungte@chromium.org> > (cherry picked from commit 2b7e6b8780b4ccd32129286544a5ec433dba98f3) > Reviewed-on: https://chromium-review.googlesource.com/432143 > Commit-Queue: Hung-Te Lin <hungte@chromium.org> > TBR=hungte@chromium.org,kitty.liu@intel.com,shunhsingou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG= chromium:683117 Change-Id: I4993d0bfac484c67fbcf1ce4a0d8cb5ea3967724 Reviewed-on: https://chromium-review.googlesource.com/445836 Tested-by: Jongpil Jung <jongpil19.jung@samsung.com> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Jongpil Jung <jongpil19.jung@samsung.com> [modify] https://crrev.com/73233b4e03d08b3162380b146ee0e0ab0ff841ce/py/tools/disk_space.py [delete] https://crrev.com/50a5866f6785fa2c7ec993cdddb9500a6c27008a/misc/no_space.html [modify] https://crrev.com/73233b4e03d08b3162380b146ee0e0ab0ff841ce/init/goofy.d/presenter/setup_chrome.sh [modify] https://crrev.com/73233b4e03d08b3162380b146ee0e0ab0ff841ce/sh/goofy_control.sh
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by hungte@chromium.org
, Jan 20 2017