New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683115 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Migrate Media-related functions to use url::Origin in RederFrameHostDelegate

Project Member Reported by guidou@chromium.org, Jan 20 2017

Issue description

Currently, they are using GURL for origins.
 

Comment 1 by guidou@chromium.org, Jan 20 2017

This includes MediaStreamRequest, used by RequestMediaAccessPermission.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4b8bcb70bc34ac772e3904b110e643de0b6ff7b

commit a4b8bcb70bc34ac772e3904b110e643de0b6ff7b
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Tue Sep 12 16:41:04 2017

Use url::Origin in RenderFrameHostDelegate::CheckMediaAccessPermission

This CL replaces GURL with url::Origin as |security_origin|'s type.

Bug:  683115 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I852bbd7e55ae210f32875408c6400e2057df7c5f
Reviewed-on: https://chromium-review.googlesource.com/643346
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#501305}
[modify] https://crrev.com/a4b8bcb70bc34ac772e3904b110e643de0b6ff7b/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/a4b8bcb70bc34ac772e3904b110e643de0b6ff7b/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/a4b8bcb70bc34ac772e3904b110e643de0b6ff7b/content/browser/media/media_devices_permission_checker.cc
[modify] https://crrev.com/a4b8bcb70bc34ac772e3904b110e643de0b6ff7b/content/browser/renderer_host/media/media_stream_ui_proxy_unittest.cc
[modify] https://crrev.com/a4b8bcb70bc34ac772e3904b110e643de0b6ff7b/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/a4b8bcb70bc34ac772e3904b110e643de0b6ff7b/content/browser/web_contents/web_contents_impl.h

Comment 3 by guidou@chromium.org, Oct 10 2017

Cc: guidou@chromium.org
Owner: c.pa...@samsung.com
Status: Fixed (was: Assigned)

Sign in to add a comment