New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683109 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression

Blocked on:
issue 685244



Sign in to add a comment

Linux MSan bots are taking too long to compile

Project Member Reported by ehmaldonado@chromium.org, Jan 20 2017

Issue description

The Linux MSan (https://build.chromium.org/p/client.webrtc/builders/Linux%20MSan) and linux_msan (https://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/) bots are taking too long to compile. 

The compile step used to take usually less than 5 minutes, and now it takes almost an hour.

For the trybot it seems like the problem began with this build (it takes 1h 4m 28s to compile!): https://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/16150

For the bot in the main waterfall it seems like it began with:
https://build.chromium.org/p/client.webrtc/builders/Linux%20MSan/builds/7775 (1h 1m 36s to compile)

Or perhaps with the build before:
https://build.chromium.org/p/client.webrtc/builders/Linux%20MSan/builds/7774



 
It looks like this roll, in particular the Clang version change, caused the regression:
https://chromium.googlesource.com/external/webrtc/+/8a0d3573e70a19e1e7e15abb37b7b09d6c877ec0

Another data point, both https://build.chromium.org/p/client.webrtc/builders/Linux%20MSan/builds/7777 and https://build.chromium.org/p/client.webrtc/builders/Linux%20MSan/builds/7781 take place on slave16-c3. So even though the latter build is just 725 objects, it takes 51 minutes to build
(both after the roll)
Cc: pbos@chromium.org
Labels: Stability-Memory-MemorySanitizer
Status: Assigned (was: Untriaged)
This has severe impact on our tryserver and CQ performance, since these slow bots have become the bottleneck and jobs gets queued up waiting for these VMs to finish.

Comment 4 by glider@chromium.org, Jan 20 2017

Cc: thakis@chromium.org kcc@chromium.org euge...@chromium.org

Comment 5 by glider@chromium.org, Jan 20 2017

Note that the last commit to MSan is 286980 from 2 months ago, while the Clang version change is 289575:289944.
Maybe something has changed in the register allocator? It usually bears much more stress under MSan than in native builds.

Comment 7 by glider@chromium.org, Jan 20 2017

Kostya, Nico, there is ongoing discussion about LLVM getting slower on llvm-dev.
Any idea if the issues mentioned there are related to this particular bug?
Owner: euge...@chromium.org
I see 93% compile time regression on sqlite.c in the following clang revision range: 289575:289944.
I'll narrow it down and file an upstream bug.
Owner: thakis@chromium.org
I also see that it is fixed in the current ToT, as well as in the possible next roll candidate, r292414 (and they are even 1 or 2% faster on the two files I've tested).

So, I guess we wait for the clang roll. Assigning to Nico since I could not find a tracking bug for that.

Can you file a bug for the roll and make this one blocked on that?
Blockedon: 685244
Status: ExternalDependency (was: Assigned)
Is there an estimated time?
Owner: ehmaldonado@chromium.org
clang roll landed in chromium. i think you need to merge that to webrtc, and then let us know if it helped.
Status: Fixed (was: ExternalDependency)
Yay, the bots are now cycling way faster (~4x), so this is definitely fixed now! Thanks all!

Sign in to add a comment