New issue
Advanced search Search tips

Issue 683099 link

Starred by 1 user
Status: Assigned
Owner:
sande...@chromium.org
Cc:
ligim...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Tests]: VTVDA unittests

Project Member Reported by tkonch...@chromium.org, Jan 20 2017 
sandersd@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit:   https://codereview.chromium.org/2525143002

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=668178

Thanks,

Comment 1 by sande...@chromium.org, Jan 20 2017

Labels: -Pri-1 Pri-2
Summary: [Missing Tests]: VTVDA unittests (was: [Missing Tests]: media: Destroy VTVDA session on the decoder thread)
(Clarification: the cited bug always existed in VTVDA, it was not a regression.)

I can add a check that the pointer has been cleared in the destructor, but that won't actually prove that the bug (which isn't reliably reproducible) doesn't exist. We could instead specifically not clear it, and verify the CF refcount, but that sounds worse.

A more fundamental problem is that we don't have a GPU-enabled VTVDA test running on bots at all. Even the vda_unittest (which doesn't support mac as of now) isn't automated.

We do get integration test coverage via. the browsertests when they run on GPU bots.
►

Sign in to add a comment