New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 683094 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug

Blocking:
issue 819977


Participants' hotlists:
WebRTC-1.0-Spec-Compliance


Sign in to add a comment

RTCIceCandidate: Add missing attributes

Reported by acmesqua...@gmail.com, Jan 20 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

Steps to reproduce the problem:
RTCIceCandidate is missing attributes from the spec.

What is the expected behavior?
https://www.w3.org/TR/webrtc/#rtcicecandidate-interface

What went wrong?
Not implemented

Did this work before? No 

Does this work in other browsers? Yes

Chrome version:  57.0.2986.0 dev (64-bit)  Channel: dev
OS Version: 
Flash Version:
 
RTCIceCandidate.html
1.3 KB View Download

Comment 1 by ajha@chromium.org, Jan 23 2017

Labels: Needs-Triage-M57

Comment 2 by guidou@chromium.org, Jan 23 2017

Owner: hbos@chromium.org
Status: Assigned (was: Unconfirmed)
hbos@: can you take a look at this?
hbos@ Gentle Ping! Could you please let us know is there any latest update available on this issue?

Thanks!

Comment 4 by hbos@chromium.org, Feb 20 2017

Sorry for the late response. I have not had any time to work on this at all. Does this need to be prioritized?

Comment 5 by phistuck@gmail.com, Feb 20 2017

Those exist -
    readonly attribute DOMString               candidate;
    readonly attribute DOMString?              sdpMid;
    readonly attribute unsigned short?         sdpMLineIndex;
Those are missing -
    readonly attribute DOMString               foundation;
    readonly attribute unsigned long           priority;
    readonly attribute DOMString               ip;
    readonly attribute RTCIceProtocol          protocol;
    readonly attribute unsigned short          port;
    readonly attribute RTCIceCandidateType     type;
    readonly attribute RTCIceTcpCandidateType? tcpType;
    readonly attribute DOMString?              relatedAddress;
    readonly attribute unsigned short?         relatedPort;

I have not tested the serializer, but Chrome exposes a toJSON method.
Labels: -Needs-Triage-M57 M-58
As this issue can't be triaged from TE end removed the Needs-Triage-M57 and added appropriate milestone for this.
Labels: -M-58 M-59
Published spec now also includes ufrag
Labels: -M-59 M-60
Bumping to M60. Please correct if that's wrong.
Cc: deadbeef@chromium.org
deadbeef@, you added these to the spec in https://github.com/w3c/webrtc-pc/pull/325, do you still think it's a good idea to implement this? Nobody else has AFAICT, so just reverting it from the spec would be a quick fix to alignment :)
I think it's a good idea, yes. All of the necessary fields should already be there at the webrtc level.

Comment 12 by hbos@chromium.org, May 15 2017

It makes sense to address this after we've sorted out RTCRtpSender and friends, since that exposes candidates in a new way and will require fixing candidate-related things in the webrtc layer. RTCRtpSender -> RTCDtlsTransport -> RTCIceTransport -> RTCIceCandidate.

Comment 13 by hbos@chromium.org, Mar 7 2018

Labels: -M-60

Comment 14 by hta@chromium.org, Mar 8 2018

Blocking: 819977
Cc: guidou@chromium.org hbos@chromium.org
Owner: guidou@chromium.org
Status: Started (was: Assigned)
Per #11 this should already exist in the WebRTC layer.
Labels: OS-Android OS-Chrome OS-Fuchsia OS-Mac OS-Windows

Sign in to add a comment