New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 683093 link

Starred by 1 user
Status: WontFix
Owner:
█ joh...@chromium.org
no longer working on chrome
Closed: Jan 2017
Cc:
ligim...@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Tests]: [Notifications] Make image background white like notification background

Project Member Reported by tkonch...@chromium.org, Jan 20 2017 
johnme@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit: https://codereview.chromium.org/2522083003

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=668087

Thanks,

Comment 1 by peter@chromium.org, Jan 20 2017

Labels: -M-56 M-58
What regression are we talking about here? Is there a bug?

The image's background color is a constant. I think that the compiler would complain if the constant isn't being used.

I guess we could EXPECT_EQ(view->background()->get_color(), kImageBackgroundColor) in NotificationViewTest.TestImageSizing... In either case, this doesn't warrant a merge to M-56, probably not to M-57 either.

Comment 2 by joh...@chromium.org, Jan 23 2017

Status: WontFix (was: Assigned)
The patch was not for a regression, but rather a change suggested by the UX team. I'm going to wontfix this as I can't think of any way to write a non-trivial test for a constant having the right value.

Comment 3 by peter@chromium.org, Jan 23 2017 

Out of interest, why doesn't my idea in #c1 work?
►

Sign in to add a comment